My own version of Gnuboy. New functionalities added #2

ghost · 2017-05-23T17:54:31Z

-Screenshots
-Screencasting
-Console/debugger (beta)

A console will appear on the screen when Gnuboy is running. Type 'help' and you will see the available commands and how to take both screenshots and do screencasts.

Important: enable debugging in order to use a few of the functionalities within the debugger. Otherwise, they won't work (Error messages will appear, while normal execution will go on without any results).

-Screenshots -Screencasting -Console/debugger (beta)

rofl0r · 2017-05-23T21:59:56Z

cool!
i'm generally willing to add your enhancements, but merging a single 1000 lines patch is against all my principles. therefore i'd like to ask you to go over your changes and make one commit per new feature or logical change, so we can bring each commit to a size that's reasonable to review.
does that sound acceptable?

rofl0r

i added some comments. i'll do further review once you've come up with clean one-feature-per-commit commits.

rofl0r · 2017-05-23T22:02:13Z

cpucore.h

@@ -7,7 +7,7 @@ const static byte cycles_table[256] =
 	1, 3, 2, 2, 1, 1, 2, 1, 5, 2, 2, 2, 1, 1, 2, 1,
 	1, 3, 2, 2, 1, 1, 2, 1, 3, 2, 2, 2, 1, 1, 2, 1,
 	3, 3, 2, 2, 1, 1, 2, 1, 3, 2, 2, 2, 1, 1, 2, 1,
-	3, 3, 2, 2, 3, 3, 3, 1, 3, 2, 2, 2, 1, 1, 2, 1,
+	3, 3, 2, 2, 1, 3, 3, 3, 3, 2, 2, 2, 1, 1, 2, 1,


why was this changed? please put into a single commit explaining.

rofl0r · 2017-05-23T22:03:06Z

Makefile.in

@@ -26,7 +26,7 @@ FB_LIBS =
 SVGA_OBJS = sys/svga/svgalib.o sys/pc/keymap.o @JOY@ @SOUND@


please no gratuitous modechanges, thanks.
(refering to Makefile.in 100644 → 100755, and the same for almost all other files)

rofl0r · 2017-05-23T22:03:51Z

README

@@ -45,20 +45,19 @@ all of the following and much more:
  Wave pattern memory corruption when sound channel 3 is played.
  Pad, timer, divide counter, and other basic hardware registers.
  CGB double-speed CPU mode.
-  Sorting sprites by X coordinate in DMG mode.


why was this block moved to section below?

rofl0r · 2017-05-23T22:04:49Z

README.md

@@ -0,0 +1,22 @@
+# mygnuboy
+My own version of gnuboy emulator


i dont think we want to change the name to "mygnuboy". it should stay as close to laguna's original as possible.

rofl0r · 2017-05-23T22:05:19Z

README.md

+	scrot
+	ffmpeg
+
+	Both of them available via apt-get 


not all the world is debian/ubuntu.

rofl0r · 2017-05-23T22:06:00Z

README.md

+
+
+	scrot
+	ffmpeg


if you want to add third-party dependency, then please make them optional. ffmpeg is a huge download and takes considerable time to build.

rofl0r · 2017-05-23T22:06:57Z

cpu.c

@@ -641,7 +643,7 @@ int cpu_emulate(int cycles)
 		break;
 	case 0x3C: /* INC A */
 		INC(A); break;
-			
+


please no gratuitous whitespace changes.

rofl0r · 2017-05-23T22:08:05Z

cpu.h

-void sound_advance(int cnt);
-void cpu_timers(int cnt);
-int cpu_emulate(int cycles);
+int return_globalpc();


what's the point of removing these decls ?
it looks more and more as if you just copied the "community edition" gnuboy over this one.

rofl0r · 2017-05-23T22:08:56Z

debian/changelog

+  * Acknowledging previous NMUs, thanks Moritz! closes: #711112. 
+
+ -- Davide Puricelli (evo) <[email protected]>  Sun, 30 Jun 2013 16:54:28 +0200
+


i dont think debian specific files have any reason to go into this repo.

rofl0r · 2017-05-24T15:54:48Z

since you deleted your fork of my repo, i assume you're not interested of cleaning up your work. thanks for nothing.

ghost · 2017-05-24T17:22:51Z

Hello rofl0r!

Of course I am interested on it, but since this is the first time I ever participate in a free software project and I realised I did a few things wrong, I will work on what I wanted to commit so that it fits and respects all the things you remarked before.

I still want to contribute with a debugger functionality. Regarding both the screencast and the snapshot functionalities, which could be an appropriate approach when trying to keep the program available for several distributions?

I will try to commit every change so that everyone can keep track of what I have done in a proper way.

Thank you, and sorry for the inconvenience :)

rofl0r · 2017-05-24T21:14:54Z

oh ok. did you see the other issue #1 ?
basically there are 2 versions of gnuboy: the one that i call in my mind the "mob" version, which is what debian has in their repos. it is the community's continuation of laguna's project, which has some new features and changes. then there's this version which is basically the pure version of when laguna abandoned the project, plus some minor fixes to make it work on current systems. afaict, your work is based on the community/mob version; so maybe that one would be better suited to file a PR against.

rofl0r · 2017-05-24T23:43:57Z

Regarding both the screencast and the snapshot functionalities, which could be an appropriate approach when trying to keep the program available for several distributions?

oh sorry, i overlooked the question in my previous reply.
what other (well-behaving) programs do in such a situation is to assume user wants all features, and then test if the required dependencies for each feature are available; if not, turn it off.
for example in case of feature "record video": a configure option --enable-ffmpeg which defaults to "auto" which means a compile test is done against ffmpeg.
this could either involve using pkg-config to check for its existence, or using gcc helloworld.c -lavcodec. if the latter succeeds it signifies that ffmpeg is installed; but then you also need to check for its headers, that would mean compiling a test program which includes a ffmpeg header such as:

#include <libavcodec/avcodec.h>
int main() { return 0; }

if the user passes --disable-ffmpeg, than all tests are skipped and ffmpeg support is not compiled in.
in the code this would look like

#ifdef WANT_FFMPEG
record_video();
#endif

rofl0r · 2017-05-24T23:45:44Z

btw regarding the snapshot functionality:
there's already a screen buffer that has the entire bitmap that's put on the screen. what prevents you from just saving that to disk directly (for example using a .bmp header), instead of pulling in a dependency on scrot ?

My own version of Gnuboy. New functionalities added:

cf9d98f

-Screenshots -Screencasting -Console/debugger (beta)

rofl0r requested changes May 23, 2017

View reviewed changes

rofl0r mentioned this pull request May 24, 2017

update to latest code #1

Open

rofl0r closed this May 24, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

My own version of Gnuboy. New functionalities added #2

My own version of Gnuboy. New functionalities added #2

ghost commented May 23, 2017

rofl0r commented May 23, 2017

rofl0r left a comment

rofl0r May 23, 2017

rofl0r May 23, 2017

rofl0r May 23, 2017

rofl0r May 23, 2017

rofl0r May 23, 2017

rofl0r May 23, 2017

rofl0r May 23, 2017

rofl0r May 23, 2017

rofl0r May 23, 2017

rofl0r commented May 24, 2017

ghost commented May 24, 2017 •

edited by ghost

Loading

rofl0r commented May 24, 2017

rofl0r commented May 24, 2017

rofl0r commented May 24, 2017

		@@ -26,7 +26,7 @@ FB_LIBS =
		SVGA_OBJS = sys/svga/svgalib.o sys/pc/keymap.o @JOY@ @SOUND@

		* Acknowledging previous NMUs, thanks Moritz! closes: #711112.

		-- Davide Puricelli (evo) <[email protected]> Sun, 30 Jun 2013 16:54:28 +0200

My own version of Gnuboy. New functionalities added #2

My own version of Gnuboy. New functionalities added #2

Conversation

ghost commented May 23, 2017

rofl0r commented May 23, 2017

rofl0r left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rofl0r commented May 24, 2017

ghost commented May 24, 2017 • edited by ghost Loading

rofl0r commented May 24, 2017

rofl0r commented May 24, 2017

rofl0r commented May 24, 2017

ghost commented May 24, 2017 •

edited by ghost

Loading