Fix flaky export service spec #4919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue, but related to #4557
Description
This is the same fix for a previously flaky test fix #4862. All the tests for this service are duplicated (with and without a feature flag enabled), so when I made that PR I accidentally only applied the fix to half the tests so this PR is needed for the other half.
See example failure here: https://github.com/rubyforgood/human-essentials/actions/runs/12622483605/job/35170445844
Type of change
How Has This Been Tested?
Hard to replicate the failure because it depends on Postgres returning records from a
Request.allquery not in the order of creation (id) which it tends to do when there are only a few records in the table. But it should fix the issue.