Improve locale #5371
Merged
Improve locale #5371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w-masahiro-ct
force-pushed
the
improve-locale
branch
2 times, most recently
from
261cadc to
7b38d59
Compare
w-masahiro-ct
force-pushed
the
improve-locale
branch
from
7b38d59 to
cc45a1f
Compare
segiddins
approved these changes
Jan 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5371 +/- ##
==========================================
- Coverage 97.14% 94.26% -2.88%
==========================================
Files 458 451 -7
Lines 9584 9450 -134
==========================================
- Hits 9310 8908 -402
- Misses 274 542 +268 ☔ View full report in Codecov by Sentry. |
|
@w-masahiro-ct can you please revert cosmetic changes (like quoting changes in views)? |
w-masahiro-ct
force-pushed
the
improve-locale
branch
from
c865896 to
1072807
Compare
|
@segiddins @simi If there are no issues, could you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I improved locale.
I would be happy if you could take a look.