Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import mini_core in test directory #583

Closed
wants to merge 3 commits into from

Conversation

g4titanx
Copy link
Contributor

@g4titanx g4titanx commented Dec 30, 2024

this PR fixes issues #571

@antoyo
Copy link
Contributor

antoyo commented Jan 2, 2025

Thanks for your contribution!

According to the error in the CI, it seems like you would need to find a way to import mini_core so that it's found by those tests.

Importing mini_core is one way to solve the issue. The other would be to use include! but I don't know if it's easier.

Also, please put the documentation changes in a separate PR: I'd like to review this stuff separately.

@g4titanx g4titanx changed the title import mini_core in test direcorty and improve doc for new contributors import mini_core in test directory Jan 3, 2025
@g4titanx
Copy link
Contributor Author

g4titanx commented Jan 3, 2025

hey @antoyo could you help clarify the test setup and how mini_core should be made available to the tests

@antoyo
Copy link
Contributor

antoyo commented Jan 3, 2025

It seems the include! isn't available without std, from what I can see.
So, I guess you should try to make your first idea of importing the module normally work.
To do so, you would probably need to specify where to find mini_core by adding a cli flag here.

What info do you need on the test setup?

@g4titanx
Copy link
Contributor Author

g4titanx commented Jan 3, 2025

hey, thanks, , i'm running into some issues though, i can't successfully run ./y.sh test --mini-tests locally to verify where mini_core gets built (getting cargo binary errors)
i'm not entirely sure about the correct path to add to the compiler args in lang_tests_common.rs

so, how/where does mini_core get built in the setup?
or more specifically, what's the correct path i should add to the compiler args here to find mini_core?

@antoyo
Copy link
Contributor

antoyo commented Jan 3, 2025

hey, thanks, , i'm running into some issues though, i can't successfully run ./y.sh test --mini-tests locally to verify where mini_core gets built (getting cargo binary errors)

That's the first thing you should try to get working.
Can you please post the cargo errors?

@g4titanx
Copy link
Contributor Author

g4titanx commented Jan 3, 2025

hey, thanks, , i'm running into some issues though, i can't successfully run ./y.sh test --mini-tests locally to verify where mini_core gets built (getting cargo binary errors)

That's the first thing you should try to get working. Can you please post the cargo errors?

sure!

run:
./y.sh test --mini-tests

result:
[BUILD] build system
error: the 'cargo' binary, normally provided by the 'cargo' component, is not applicable to the 'nightly-2024-08-11-aarch64-apple-darwin' toolchain

and i've got the necessary toolchains installed

@g4titanx
Copy link
Contributor Author

g4titanx commented Jan 7, 2025

@antoyo

@antoyo
Copy link
Contributor

antoyo commented Jan 7, 2025

Sorry, I forgot about this.

Let me first check whether GCC works on aarch64 Mac today.
It used to not be supported, but perhaps it is now.

@antoyo
Copy link
Contributor

antoyo commented Jan 7, 2025

From what I can see here, it seems like it's still not supported.
Were you able to compile libgccjit on your computer?

@g4titanx
Copy link
Contributor Author

g4titanx commented Jan 8, 2025

From what I can see here, it seems like it's still not supported. Were you able to compile libgccjit on your computer?

no i wasn't able to but i've got a pc with arch on it and im gonna move development there and try to run the pogram
on it

@antoyo
Copy link
Contributor

antoyo commented Jan 8, 2025

no i wasn't able to but i've got a pc with arch on it and im gonna move development there and try to run the pogram
on it

Ok. If you need any help to do the setup, don't hesitate to ask questions.

@antoyo
Copy link
Contributor

antoyo commented Jan 13, 2025

I implemented this in this commit as I needed it to simplify the last sync.

@antoyo antoyo closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants