Merge pull request #63 from josevalim/patch-1

Simplify diagnostic handling
sasa1977 · Dec 18, 2023 · 61d0e0e · 61d0e0e
2 parents 1d06d62 + 49334eb
commit 61d0e0e
Showing 1 changed file with 9 additions and 26 deletions.
diff --git a/lib/boundary/mix/tasks/compile/boundary.ex b/lib/boundary/mix/tasks/compile/boundary.ex
@@ -394,31 +394,14 @@ defmodule Mix.Tasks.Compile.Boundary do
   end
 
   def diagnostic(message, opts \\ []) do
-    diagnostic =
-      %Mix.Task.Compiler.Diagnostic{
-        compiler_name: "boundary",
-        details: nil,
-        file: nil,
-        message: message,
-        position: 0,
-        severity: :warning
-      }
-      |> Map.merge(Map.new(opts))
-
-    cond do
-      diagnostic.file == nil ->
-        %{diagnostic | file: "unknown"}
-
-      diagnostic.position == 0 and File.exists?(diagnostic.file) ->
-        num_lines =
-          diagnostic.file
-          |> File.stream!()
-          |> Enum.count()
-
-        %{diagnostic | position: {1, 0, num_lines + 1, 0}}
-
-      true ->
-        diagnostic
-    end
+    %Mix.Task.Compiler.Diagnostic{
+      compiler_name: "boundary",
+      details: nil,
+      file: nil,
+      message: message,
+      position: 0,
+      severity: :warning
+    }
+    |> struct(opts)
   end
 end