Skip to content

Commit

Permalink
Remove js-yaml peer dependency and mentions of removed webpackConfigL…
Browse files Browse the repository at this point in the history
…oader (#1678)

Co-authored-by: Alexey Romanov <[email protected]>
  • Loading branch information
alexeyr-ci and alexeyr authored Jan 16, 2025
1 parent 846d02d commit 611b00e
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Changes since the last non-beta release.
#### Fixed

- Separated streamServerRenderedReactComponent from the ReactOnRails object in order to stop users from getting errors during webpack compilation about needing the `stream-browserify` package. [PR 1680](https://github.com/shakacode/react_on_rails/pull/1680) by [judahmeek](https://github.com/judahmeek).
- Removed obsolete `js-yaml` peer dependency. [PR 1678](https://github.com/shakacode/react_on_rails/pull/1678) by [alexeyr-ci](https://github.com/alexeyr-ci).

### [14.1.0] - 2025-01-06

Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
react_on_rails (15.0.0.alpha.1)
react_on_rails (14.1.0)
addressable
connection_pool
execjs (~> 2.5)
Expand Down
2 changes: 0 additions & 2 deletions docs/additional-details/manual-installation-overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ The only requirements within this directory for basic React on Rails integration
1. Provide server rendering if you wish to use that feature.
1. Your JavaScript code "registers" any components and stores per the ReactOnRails APIs of ReactOnRails.register(components) and ReactOnRails.registerStore(stores). See [our javascript API docs](https://www.shakacode.com/react-on-rails/docs/api/javascript-api/) and the [ReactOnRails.js source](https://github.com/shakacode/react_on_rails/tree/master/node_package/src/ReactOnRails.js).
1. Set your registration file as an "entry" point in your Webpack configs.
1. Add the [Manifest plugin](https://github.com/danethurber/webpack-manifest-plugin) to your config.
The default path: `public/webpack` can be loaded with webpackConfigLoader as shown in the dummy example.
1. You create scripts in `client/package.json` per the example apps. These are used for building your Webpack assets. Also do this for your top level `package.json`.

## Rails Steps (outside of /client)
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/webpack-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ You can access values in the `config/shakapacker.yml`
const { config, devServer } = require('shakapacker');
```

You will want consider using some of the same values set in these files:
You will want to consider using some of the same values set in these files:

* https://github.com/shakacode/shakapacker/blob/master/package/environments/base.js
* https://github.com/shakacode/shakapacker/blob/master/package/environments/development.js
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
"@babel/runtime-corejs3": "^7.12.5"
},
"peerDependencies": {
"js-yaml": ">= 3.0.0",
"react": ">= 16",
"react-dom": ">= 16"
},
Expand Down

0 comments on commit 611b00e

Please sign in to comment.