-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export stream functions only for node bundles #1681
Export stream functions only for node bundles #1681
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -72,12 +72,13 @@ | |||
"fs": false | |||
}, | |||
"scripts": { | |||
"yalc-postinstall": "yalc link react-on-rails", | |||
"preinstall": "yarn run link-source && yalc add --link react-on-rails", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not part of the original PR goal, this change addressed the issue of occasionally failing to utilize the latest updates in the local react-on-rails
.
42b1830
into
judahmeek/separate-streaming-functions
* separate streamServerRenderedReactComponent from ReactOnRails * add changelog entry * Export stream functions only for node bundles (#1681) * Add export for ReactOnRails for Node.js which supports streaming * adding default export from ReactOnRails module in ReactOnRails.node --------- Co-authored-by: Abanoub Ghadban <[email protected]>
Summary
We can't remove
streamServerRenderedReactComponent
from theReactOnRails
object in the global scope because it is directly invoked by the JavaScript code responsible for server-side rendering of streamed components, as demonstrated here.It is not feasible to use:
within the Node.js renderer.
To avoid errors, we kept
streamServerRenderedReactComponent
inside theReactOnRails
object when the package is imported in a Node.js bundle. Importing this function directly in a non-Node.js bundle, such as a web bundle, will result in a runtime error.Pull Request checklist
Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by
~
.Add the CHANGELOG entry at the top of the file.
Other Information
Remove this paragraph and mention any other important and relevant information such as benchmarks.
This change is