Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit resource likes #87

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Limit resource likes #87

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a36fd9f
added shescoding_likes to document.cookie
probinson2015 Apr 29, 2016
52d23c9
comments updated
probinson2015 Apr 29, 2016
75fe78a
ability to add multiple key value pairs to shescoding cookie
probinson2015 Apr 30, 2016
1960c32
added processLike function in order to process likes before decrement…
probinson2015 May 4, 2016
2a368b4
added processLike function that sends to incrementLike if resource is…
probinson2015 May 17, 2016
6b0b3e5
removed console logs
probinson2015 May 17, 2016
911663c
Merge branch 'master' into LimitResourceLikes
probinson2015 Jul 2, 2016
94e617b
updated indentation. modified resource id so that it doesn't rely on …
probinson2015 Jul 2, 2016
936135d
likes now only increase or decrease once. cookie is updating accordingly
probinson2015 Jul 31, 2016
5957b98
unlike route added. unlike method added to resource controller.
probinson2015 Jul 31, 2016
d6a2c34
Merge branch 'master' into LimitResourceLikes
Jul 21, 2018
a62eec8
updated to accomodate unlikes, added resource update functions
Jul 24, 2018
eda5ad3
remove unused controller action
Jul 24, 2018
41da8b0
fix typo and slice parameters.
probinson2015 Oct 15, 2018
902dae5
Merge branch 'master' into LimitResourceLikes
Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion app/assets/javascripts/resources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,55 @@ function scrollToTop(event) {
$('html, body').animate({scrollTop: 0}, 'slow');
}

function getCookie(cname) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here saying that this code is copied from W3 Schools, with the link: http://www.w3schools.com/js/js_cookies.asp

var name = cname + "=";
var ca = document.cookie.split(';');
for(var i = 0; i <ca.length; i++) {
var c = ca[i];
while (c.charAt(0)==' ') {
c = c.substring(1);
}
if (c.indexOf(name) == 0) {
return c.substring(name.length,c.length);
}
}
return "";
}

function setCookie(cname, cvalue, exdays) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - thanks!

var d = new Date();
d.setTime(d.getTime() + (exdays*24*60*60*1000));
var expires = "expires="+d.toUTCString();
document.cookie = cname + "=" + cvalue + "; " + expires;
}

function processLike(event, target){
event.preventDefault();
resourceID = target.parentNode.parentNode.action.split('/')[4]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way you rely on the absolute URL containing 5 forward slashes ('/'), which is not a good idea. That code would break if we change our URL paths. What you know (and what is independent of the rest of the path) is that the URL ends on '<resource_id>/like'. So instead of getting the 5th element of the array, I would use 'target.parentNode.parentNode.action.split('/').slice(-2)[0]'. That way you first reduce the array to the two last elements, and then choose the resource_id.


//create shescoding_likes cookie if it does not exist
if (getCookie("_shescoding_likes") === ""){
document.cookie = "_shescoding_likes = {}";
newValue = JSON.stringify({[resourceID]: true});
setCookie("_shescoding_likes", newValue, 365);
incrementLike(event, target);
}

//if shescoding_likes cookie does exist
else {
//check if resource id exists
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure indentations in this function are right - e.g., everything in this else should be indented further.

var oldCookie = getCookie("_shescoding_likes");
var newCookie = JSON.parse(oldCookie);

if (!(newCookie.hasOwnProperty(resourceID))){
newCookie[resourceID] = true;
newValue = JSON.stringify(newCookie);
setCookie("_shescoding_likes", newValue, 365);
incrementLike(event, target);
};
};
};

function incrementLike(event, target) {
event.preventDefault();
var form = $(target).parents('form');
Expand All @@ -45,4 +94,5 @@ function incrementLike(event, target) {
$.ajax(form.attr("action"), {
type: "POST"
});
}
}

2 changes: 1 addition & 1 deletion app/views/resources/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@

// Ajax Like
$(".heart").click(function(e){
incrementLike(e, this);
processLike(e, this);
});
});
</script>
Expand Down