Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] refactor ghwf functional tests go dependency caching #1632

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented Jan 24, 2025

Description:

This PR optimizes the functional test workflow by properly implementing go dependency caching, which was previously not utilized correctly. The update results in significant performance improvements by reducing test completion time and saving on CPU and network resources.

Changes:

  • Implemented caching for functional test execution and removed prevous caching implementation.
  • Added make action to run functional tests to help utilize caching.
  • Standardized the version of Go used in testing.
  • Added better documentation.

Performance Improvements:

  • Without caching:

    • Step: Run functional-tests
    • Link to run
    • Completion time: 4m34s
  • With caching:

    • Step: Run functional-tests
    • Link to run
    • Completion time: 3m1s

Highlights:

  • The caching optimization reduces the step that previously took the most time in the functional tests by about 1m30s, resulting in a 33% performance increase in time to completion for the step.
  • Overall, the full github workflow that runs this test had it's time reduced from approximately 5m45s to 4m15s, yielding an overall 26% improvement in test run time.

@jvoravong jvoravong requested review from a team as code owners January 24, 2025 19:40
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@jvoravong
Copy link
Contributor Author

Looks like some of the eks upgrade tests are failing. Checking it out, can't tell yet if it is due to a previous existing issue or due to the changes in this PR.

@jvoravong
Copy link
Contributor Author

There was an issue with our eks upgrade tests where the environment wasn't cleaned up before the tests ran. This caused failures when the environment was left in an inconsistent state from a previous test run, often due to a hard failure of a previous test run. I added a quick 2-line fix to ensure proper cleanup before each test.

@jvoravong jvoravong requested review from jinja2 and atoulme January 24, 2025 22:23
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants