-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] refactor ghwf functional tests go dependency caching #1632
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Antoine Toulme <[email protected]>
5397510
to
c25c46d
Compare
Looks like some of the eks upgrade tests are failing. Checking it out, can't tell yet if it is due to a previous existing issue or due to the changes in this PR. |
c25c46d
to
7b49f20
Compare
There was an issue with our eks upgrade tests where the environment wasn't cleaned up before the tests ran. This caused failures when the environment was left in an inconsistent state from a previous test run, often due to a hard failure of a previous test run. I added a quick 2-line fix to ensure proper cleanup before each test. |
3f72738
to
0e07378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description:
This PR optimizes the functional test workflow by properly implementing go dependency caching, which was previously not utilized correctly. The update results in significant performance improvements by reducing test completion time and saving on CPU and network resources.
Changes:
Performance Improvements:
Without caching:
functional-tests
With caching:
functional-tests
Highlights: