Chore: Setup testing library #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
endigo9740
requested changes
May 4, 2024
src/lib/hooks/Counter.svelte
Outdated
| @@ -0,0 +1,9 @@ | |||
| <script lang="ts"> | |||
There was a problem hiding this comment.
Just adding a reminder we should remove this component and it's test spec before merge. We don't need it in the library itself. It can remain until the PR audit is complete though.
There was a problem hiding this comment.
Exactly my thought, left it in there so you can see for yourself if you wish to do so. It is not meant to be part of the PR.
endigo9740
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43