Fix linting errors and address review comments

Signed-off-by: Vishal Thapar <[email protected]>
skitt · Mar 17, 2021 · ca7f7ab · ca7f7ab
1 parent 148f091
commit ca7f7ab
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/pkg/subctl/cmd/gather.go b/pkg/subctl/cmd/gather.go
@@ -101,6 +101,8 @@ func gatherConnectivity(status *cli.Status, dataType string) error {
 		status.QueueWarningMessage("Gather Connectivity Logs not implemented yet")
 	case Resources:
 		status.QueueWarningMessage("Gather Connectivity Resources not implemented yet")
+	default:
+		return fmt.Errorf("unsupported data type %s", dataType)
 	}
 	return nil
 }
@@ -111,13 +113,20 @@ func gatherDiscovery(status *cli.Status, dataType string) error {
 		status.QueueWarningMessage("Gather ServiceDiscovery Logs not implemented yet")
 	case Resources:
 		status.QueueWarningMessage("Gather ServiceDiscovery Resources not implemented yet")
+	default:
+		return fmt.Errorf("unsupported data type %s", dataType)
 	}
 	return nil
 }
 
 func gatherBroker(status *cli.Status, dataType string) error {
-	if dataType == Resources {
+	switch dataType {
+	case Logs:
+		status.QueueSuccessMessage("No logs to gather on Broker")
+	case Resources:
 		status.QueueWarningMessage("Gather Broker Resources not implemented yet")
+	default:
+		return fmt.Errorf("unsupported data type %s", dataType)
 	}
 	return nil
 }
@@ -128,6 +137,8 @@ func gatherOperator(status *cli.Status, dataType string) error {
 		status.QueueWarningMessage("Gather Operator Logs not implemented yet")
 	case Resources:
 		status.QueueWarningMessage("Gather Operator Resources not implemented yet")
+	default:
+		return fmt.Errorf("unsupported data type %s", dataType)
 	}
 	return nil
 }