Add possibility to specify non-mandatory timeout, length and offset params #78
Conversation
change name systemRequest Label Bugfix error at the ffw/BasicCommunication OnSystemRequest method with subType parameter which was null and which was calling. Change name systemRequest Label from 'System request' to 'requestSubType'.
…oprietary_data_exchange Bugfix error at the OnSystemRequest method and
Ypostolov
requested review from
AKalinich-Luxoft,
LitvinenkoIra,
BSolonenko and
a user
| optionLabelPath: 'content.name' | ||
| optionLabelPath: 'content.name', | ||
| classNameBindings: [ | ||
| 'SDL.SystemRequest.systemRequestViewSelectEnabled::inactiveTextField' |
There was a problem hiding this comment.
@Ypostolov please remove classNameBindings from here
app/view/sdl/SystemRequestView.js
Outdated
| } | ||
| ), | ||
|
|
||
| jsonOffsetCheckBox: Em.Checkbox.extend({ |
There was a problem hiding this comment.
@Ypostolov please add description for this control
| classNameBindings: [ | ||
| 'SDL.SystemRequest.timeoutEnabled::inactiveTextField' | ||
| ], | ||
| value:'2000', |
There was a problem hiding this comment.
@Ypostolov fix formatting
There was a problem hiding this comment.
@AKalinich-Luxoft
Fixed in 7e7031b
app/view/sdl/SystemRequestView.js
Outdated
| } | ||
| } | ||
| ), | ||
| jsonLengthCheckBox: Em.Checkbox.extend({ |
There was a problem hiding this comment.
@Ypostolov please add description for this control
There was a problem hiding this comment.
@AKalinich-Luxoft
Fixed in 7e7031b
app/view/sdl/SystemRequestView.js
Outdated
|
|
||
| } | ||
| ), | ||
| jsonTimeoutCheckBox: Em.Checkbox.extend({ |
There was a problem hiding this comment.
@Ypostolov please add description for this control
There was a problem hiding this comment.
@AKalinich-Luxoft
Fixed in 7e7031b
app/view/sdl/SystemRequestView.js
Outdated
| } | ||
| ), | ||
|
|
||
| systemRequestViewTitleCheckBox: Em.Checkbox.extend({ |
There was a problem hiding this comment.
@Ypostolov this checkbox is not needed as requestType parameter is mandatory according to HMI API. Remove this
There was a problem hiding this comment.
@AKalinich-Luxoft
Fixed in 7e7031b
css/sdl.css
Outdated
| left:485px; | ||
| } | ||
|
|
||
| #systemRequestView .systemRequestViewTitleCheckBox { |
There was a problem hiding this comment.
@Ypostolov this checkbox is not needed as requestType parameter is mandatory according to HMI API. Remove this
There was a problem hiding this comment.
@AKalinich-Luxoft
Fixed in 7e7031b
app/view/sdl/SystemRequestView.js
Outdated
| offsetEnabled: true, | ||
| lengthEnabled: true, | ||
| timeoutEnabled: true, | ||
| systemRequestViewSelectEnabled: true, |
There was a problem hiding this comment.
@Ypostolov remove this flag
There was a problem hiding this comment.
@AKalinich-Luxoft
Fixed in 7e7031b
app/view/sdl/SystemRequestView.js
Outdated
| FFW.BasicCommunication.OnSystemRequest( | ||
| element._parentView.systemRequestViewSelect.selection.name, | ||
| viewSelect, | ||
| element._parentView.fileNameInput.value, | ||
| element._parentView.urlsInput.value, |
There was a problem hiding this comment.
@Ypostolov please add checkbox and all needed staff for urlsInput as this is not a mandatory parameter according to HMI API
There was a problem hiding this comment.
@AKalinich-Luxoft
Fixed in 7e7031b
app/view/sdl/SystemRequestView.js
Outdated
| appID, | ||
| offset, | ||
| length, | ||
| timeout, |
There was a problem hiding this comment.
@Ypostolov please remove comma after timeout as HMI would not run on this commit
There was a problem hiding this comment.
@AKalinich-Luxoft
Fixed in 7e7031b
AKalinich-Luxoft
changed the title
There was a problem hiding this comment.
url is also not a mandatory paramter in HMI API spec, need an additional checkbox for it. This also apply to the new added parameter RequestSubType in https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0083-Expandable-design-for-proprietary-data-exchange.md
This line before the fix was giving the error NavigationController.js:52 Uncaught TypeError: this.model.push is not a function This fix now pushes location to the LocationDetails array of the navigation model.
Timeout sequence is managed by Core for PROPRIETARY mode, and HTTP header is only added to snapshot on the first attempt.
Ypostolov
force-pushed
the
fix/change_values_fileType_in_onSystemRequest
branch
2 times, most recently
from
af7dce2 to
973f2e0
Compare
offset, length, timeout in OnSystemRequest also added request subtype field with checkbox
Ypostolov
force-pushed
the
fix/change_values_fileType_in_onSystemRequest
branch
from
973f2e0 to
6e98b3a
Compare
Added ability to set parameters manually by user of fileType, offset, length, timeout in OnSystemRequest on Web HMI, also there is functionality to send not mandatory parameters.