Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test, monitor): python pip support for local wheel files specifiers #5660

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

gemaxim
Copy link
Contributor

@gemaxim gemaxim commented Jan 9, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

It bumps the snyk-python-plugin package, introducing the following:

Where should the reviewer start?

The linked PRs mentioned above. The existing acceptance tests for python projects in the cli, as well as the tests added in the plugin cover these changes.

The changed acceptance tests for newly supported local whl files.

The automated tests for the plugin support for whl files:

How should this be manually tested?

Create a python project similar to the test fixture added in the PR - snyk/snyk-python-plugin@b42e5fc#diff-2944fcfe76ba8f2b7aa23aac36d2636586d68247619b29a259533d36255cfd27.
Run pip install -r requirements.txt.
Run snyk test --comand=python3 and receive a successful response.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/OSM-2206

@gemaxim gemaxim self-assigned this Jan 9, 2025
@gemaxim gemaxim changed the title feat: [OSM-2206] python support for local wheel files specifiers feat(test, monitor): python pip support for local wheel files specifiers Jan 9, 2025
@gemaxim gemaxim marked this pull request as ready for review January 9, 2025 08:17
@gemaxim gemaxim requested a review from a team as a code owner January 9, 2025 08:17
@thisislawatts
Copy link
Member

I am curious about this statement;
and the existing acceptance tests for python projects in the cli, as well as the tests added in the plugin cover these changes.
If there are tests in the CLI repo which test this behaviour why have there been no changes, or additions, to the tests to capture the new functionality?

@gemaxim
Copy link
Contributor Author

gemaxim commented Jan 9, 2025

I am curious about this statement; and the existing acceptance tests for python projects in the cli, as well as the tests added in the plugin cover these changes. If there are tests in the CLI repo which test this behaviour why have there been no changes, or additions, to the tests to capture the new functionality?

@thisislawatts I think the interaction between cli and the plugin is the same. I might have used functionality wrong, as these are changes for supporting a very specific type of dependencies accepted by pip. If we add acceptance tests for all these cases, we would have duplicated the tests in the plugin. The basic functionality of the plugin is the same: returning dep graphs for requirements.txt input files.

@gemaxim gemaxim force-pushed the feat/OSM-2206/python-local-whl-files-support branch 5 times, most recently from df9b971 to 92617f4 Compare January 13, 2025 14:14
@gemaxim gemaxim force-pushed the feat/OSM-2206/python-local-whl-files-support branch from 92617f4 to 42675eb Compare January 13, 2025 14:32
@gemaxim
Copy link
Contributor Author

gemaxim commented Jan 13, 2025

@thisislawatts I updated the tests here after I merged this PR

@thisislawatts thisislawatts merged commit 04c66e9 into main Jan 13, 2025
8 checks passed
@thisislawatts thisislawatts deleted the feat/OSM-2206/python-local-whl-files-support branch January 13, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants