[f2dace/dev, fortran] Instead of using parfor everywhere, give every transforms their unique short names.
#1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcopik
reviewed
Jan 21, 2025
| @@ -2239,7 +2239,7 @@ def par_Decl_Range_Finder(node: ast_internal_classes.Array_Subscript_Node, | |||
| newbody.append( | |||
| ast_internal_classes.Decl_Stmt_Node(vardecl=[ | |||
| ast_internal_classes.Symbol_Decl_Node( | |||
| name="tmp_parfor_" + str(count + len(rangepos) - 1), type="INTEGER", sizes=None, init=None, | |||
There was a problem hiding this comment.
parDeclRangeFinder is called from many different transformations. Do you think this can still cause name collisions? if yes, then we can change it by passing a custom prefix from each transform
| @@ -714,20 +714,20 @@ def visit_Execution_Part_Node(self, node: ast_internal_classes.Execution_Part_No | |||
| initrange = i[0] | |||
| finalrange = i[1] | |||
| init = ast_internal_classes.BinOp_Node( | |||
| lval=ast_internal_classes.Name_Node(name="tmp_parfor_" + str(self.count + range_index)), | |||
| lval=ast_internal_classes.Name_Node(name="tmp_lbrt_" + str(self.count + range_index)), | |||
There was a problem hiding this comment.
Same here - this is a base used by many intrinsics. Two different intrinsic replacements can emit the same tmp_lbrt_0, for example.
If this is a problem for name collision, then I will change the implementation to pass a custom prefix from each intrinsic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsurprisingly, this "fix" brings out another two million bugs out of the woodwork. Surprisingly, this wasn't noticed earlier.
Before, the added variables had name collisions (possibly even type collisions), that passed the typical validation checks until one starts to really look at the built graphs.