Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Directory file source #232

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

spenserblack
Copy link
Owner

@spenserblack spenserblack commented Oct 18, 2023

To Do

  • Some sort of testing for Directory
  • Way to use directory file source from CLI
  • Support ignoring files and read .gitignore by default (ignore might be a good crate)

@spenserblack spenserblack added the semver-minor This pull request bumps the minor version label Oct 18, 2023
@spenserblack spenserblack linked an issue Oct 18, 2023 that may be closed by this pull request
@spenserblack spenserblack force-pushed the feature/196/directory-filesource branch 3 times, most recently from 1cd54aa to 9a56a8e Compare October 23, 2023 15:08
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #232 (582e90c) into main (1fe7119) will increase coverage by 1.47%.
The diff coverage is 60.41%.

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   83.10%   84.57%   +1.47%     
==========================================
  Files          16       17       +1     
  Lines         580      616      +36     
==========================================
+ Hits          482      521      +39     
+ Misses         98       95       -3     
Flag Coverage Δ
84.57% <60.41%> (+1.47%) ⬆️
macOS-latest 84.33% <60.41%> (+1.49%) ⬆️
ubuntu-latest 79.96% <60.41%> (+1.12%) ⬆️
windows-latest 73.24% <14.58%> (-4.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gengo/src/file_source/mod.rs 100.00% <ø> (+100.00%) ⬆️
gengo/src/lib.rs 86.79% <ø> (ø)
gengo/src/file_source/directory.rs 95.65% <95.65%> (ø)
gengo-bin/src/cli.rs 76.23% <28.00%> (-10.13%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@spenserblack spenserblack force-pushed the feature/196/directory-filesource branch 2 times, most recently from 1647628 to f2c2e11 Compare November 3, 2023 14:32
This will analyze a *directory* instead of a git revision. This
currently can have pretty bad performance due to reading files that
would otherwise be ignored, such as the `target/` directory.
This will cause several files listed in `.gitignore` or `.ignore`, as
well as dotfiles (e.g. `.git`) to be ignored by default, which should
help prevent unwanted files from being scanned and included in
statistics.
@spenserblack spenserblack force-pushed the feature/196/directory-filesource branch from 6b5c32c to 21542ee Compare November 8, 2023 14:25
@spenserblack spenserblack marked this pull request as ready for review November 8, 2023 14:25
@spenserblack spenserblack merged commit 280bee4 into main Nov 8, 2023
10 of 11 checks passed
@spenserblack spenserblack deleted the feature/196/directory-filesource branch November 8, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor This pull request bumps the minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic Directory FileSource
1 participant