Skip to content

Commit

Permalink
fix(core): Address ignored fields from test halconfig (#102)
Browse files Browse the repository at this point in the history
* fix(test): Remove unused fields from test halconfig

This commit removes fields that are not used by kleat from the
test halconfig.

* feat(proto): Add some missing protos

These are fields that Halyard defaults but doesn not expose commands
for editing (though users can still manuall set them). In order to
preserve backwards-compatibility for users migrating from Halyard we
should still support reading them. Ideally the fields should be defaulted
to something sensible in the service, but this will not affect migrating
users who already have them specified.

* fix(proto): Fix mis-spelled requiredGroupMembership

This was incorrectly included as requiredGroupMemberships in a number
of protos.

* feat(proto): Remove experimental flag

As we're not using optional protos, remove the experimental flag
as we don't need it anymore.

* chore(core): Bump deps and run go mod tidy
  • Loading branch information
ezimanyi authored Jun 17, 2020
1 parent 8e94fac commit 03538e3
Show file tree
Hide file tree
Showing 33 changed files with 944 additions and 970 deletions.
76 changes: 38 additions & 38 deletions api/client/cloudprovider/appengine.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 03538e3

Please sign in to comment.