-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAT-7206: fix CircleCI on rocksdb 7.3.1. #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cebook did in later versions
…nt in 9.11.fb branch
…ub Actions replaced it
…compiler. remove windows builds because we do not do windows
matthewvon
changed the title
fix compiler warnings that block build on mac.
PLAT-7201: fix CircleCI on rocksdb 7.3.1.
Jan 22, 2025
…which is no longer available via circle)
matthewvon
changed the title
PLAT-7201: fix CircleCI on rocksdb 7.3.1.
PLAT-7206: fix CircleCI on rocksdb 7.3.1.
Jan 22, 2025
Reminder from Paul P: we do not list macOS as a production environment (like Windows), not wasting any more time trying to fix. |
paulplace
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used same syntax as Facebook did in later versions