Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat_: SensitiveString type #6190

Merged
merged 7 commits into from
Dec 11, 2024
Merged

feat_: SensitiveString type #6190

merged 7 commits into from
Dec 11, 2024

Conversation

igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Dec 10, 2024

Closes #5678

Just the implementation & tests for now.
If all good, will add usage in a separate PR.

Draft of usage here:

@status-im-auto
Copy link
Member

status-im-auto commented Dec 10, 2024

Jenkins Builds

Click to see older builds (48)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8b507f8 #1 2024-12-10 23:28:26 ~4 min ios 📦zip
✔️ 8b507f8 #1 2024-12-10 23:28:51 ~4 min windows 📦zip
✖️ 8b507f8 #1 2024-12-10 23:28:54 ~4 min tests 📄log
✔️ 8b507f8 #1 2024-12-10 23:30:35 ~6 min linux 📦zip
✔️ 8b507f8 #1 2024-12-10 23:30:39 ~6 min android 📦aar
✔️ 8b507f8 #1 2024-12-10 23:31:34 ~7 min macos 📦zip
✔️ 8b507f8 #1 2024-12-10 23:31:43 ~7 min tests-rpc 📄log
✔️ 8b507f8 #1 2024-12-10 23:32:09 ~7 min macos 📦zip
✖️ ed18e94 #2 2024-12-10 23:31:32 ~2 min tests 📄log
✔️ ed18e94 #2 2024-12-10 23:32:13 ~3 min windows 📦zip
✔️ ed18e94 #2 2024-12-10 23:33:43 ~5 min ios 📦zip
✔️ ed18e94 #2 2024-12-10 23:36:23 ~5 min linux 📦zip
✔️ ed18e94 #2 2024-12-10 23:36:57 ~6 min android 📦aar
✔️ ed18e94 #2 2024-12-10 23:38:35 ~6 min tests-rpc 📄log
✔️ ed18e94 #2 2024-12-10 23:40:43 ~8 min macos 📦zip
✔️ ed18e94 #2 2024-12-10 23:40:49 ~9 min macos 📦zip
✔️ 9d13171 #3 2024-12-11 00:13:29 ~2 min windows 📦zip
✔️ 9d13171 #3 2024-12-11 00:14:24 ~3 min ios 📦zip
✔️ 9d13171 #3 2024-12-11 00:16:45 ~6 min linux 📦zip
✔️ 9d13171 #3 2024-12-11 00:16:59 ~6 min tests-rpc 📄log
✔️ 9d13171 #3 2024-12-11 00:17:00 ~6 min android 📦aar
✔️ 9d13171 #3 2024-12-11 00:18:02 ~7 min macos 📦zip
✔️ 9d13171 #3 2024-12-11 00:18:28 ~7 min macos 📦zip
✔️ 9d13171 #3 2024-12-11 00:40:54 ~30 min tests 📄log
✖️ 21c85e2 #4 2024-12-11 11:26:46 ~2 min tests 📄log
✔️ 21c85e2 #4 2024-12-11 11:26:50 ~2 min windows 📦zip
✔️ 21c85e2 #4 2024-12-11 11:29:18 ~5 min linux 📦zip
✔️ 21c85e2 #4 2024-12-11 11:29:37 ~5 min android 📦aar
✔️ 21c85e2 #4 2024-12-11 11:30:31 ~6 min tests-rpc 📄log
✔️ 21c85e2 #4 2024-12-11 11:31:35 ~7 min ios 📦zip
✔️ 21c85e2 #4 2024-12-11 11:32:15 ~8 min macos 📦zip
✔️ 21c85e2 #4 2024-12-11 11:35:44 ~11 min macos 📦zip
✔️ 75479b9 #5 2024-12-11 11:46:33 ~3 min windows 📦zip
✔️ 75479b9 #5 2024-12-11 11:49:22 ~6 min linux 📦zip
✔️ 75479b9 #5 2024-12-11 11:49:46 ~6 min tests-rpc 📄log
✔️ 75479b9 #5 2024-12-11 11:49:50 ~6 min android 📦aar
✔️ 75479b9 #5 2024-12-11 11:50:11 ~7 min ios 📦zip
✔️ 75479b9 #5 2024-12-11 11:52:40 ~9 min macos 📦zip
✔️ 75479b9 #5 2024-12-11 11:53:59 ~10 min macos 📦zip
✔️ 75479b9 #5 2024-12-11 12:13:06 ~29 min tests 📄log
✔️ 9004a0f #6 2024-12-11 12:00:07 ~3 min windows 📦zip
✔️ 9004a0f #6 2024-12-11 12:02:14 ~5 min linux 📦zip
✔️ 9004a0f #6 2024-12-11 12:02:34 ~5 min android 📦aar
✔️ 9004a0f #6 2024-12-11 12:03:30 ~6 min tests-rpc 📄log
✔️ 9004a0f #6 2024-12-11 12:03:43 ~7 min ios 📦zip
✔️ 9004a0f #6 2024-12-11 12:04:42 ~8 min macos 📦zip
✔️ 9004a0f #6 2024-12-11 12:07:16 ~10 min macos 📦zip
✖️ 9004a0f #6 2024-12-11 12:42:18 ~29 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 43b0063 #7 2024-12-11 13:00:46 ~2 min tests 📄log
✔️ 43b0063 #7 2024-12-11 13:01:26 ~3 min windows 📦zip
✔️ 43b0063 #7 2024-12-11 13:03:28 ~5 min linux 📦zip
✔️ 43b0063 #7 2024-12-11 13:03:46 ~5 min android 📦aar
✔️ 43b0063 #7 2024-12-11 13:04:14 ~6 min ios 📦zip
✔️ 43b0063 #7 2024-12-11 13:04:36 ~6 min tests-rpc 📄log
✔️ 43b0063 #7 2024-12-11 13:06:24 ~8 min macos 📦zip
✔️ 43b0063 #7 2024-12-11 13:08:38 ~10 min macos 📦zip
✔️ ae67ef1 #8 2024-12-11 13:29:23 ~3 min windows 📦zip
✔️ ae67ef1 #8 2024-12-11 13:30:13 ~4 min ios 📦zip
✔️ ae67ef1 #8 2024-12-11 13:31:45 ~5 min linux 📦zip
✔️ ae67ef1 #8 2024-12-11 13:32:16 ~6 min android 📦aar
✔️ ae67ef1 #8 2024-12-11 13:34:34 ~8 min tests-rpc 📄log
✔️ ae67ef1 #8 2024-12-11 13:37:41 ~11 min macos 📦zip
✔️ ae67ef1 #8 2024-12-11 13:56:34 ~30 min tests 📄log
✔️ ae67ef1 #9 2024-12-11 14:02:18 ~4 min macos 📦zip

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.32%. Comparing base (8b95c81) to head (ae67ef1).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
internal/security/sensitive_string.go 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6190      +/-   ##
===========================================
- Coverage    61.36%   61.32%   -0.04%     
===========================================
  Files          832      833       +1     
  Lines       109891   109909      +18     
===========================================
- Hits         67430    67399      -31     
- Misses       34581    34619      +38     
- Partials      7880     7891      +11     
Flag Coverage Δ
functional 19.62% <ø> (+0.09%) ⬆️
unit 59.97% <88.88%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/security/sensitive_string.go 88.88% <88.88%> (ø)

... and 46 files with indirect coverage changes

@igor-sirotin igor-sirotin requested a review from qfrank December 11, 2024 08:30
Copy link
Contributor

@qfrank qfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/security/sensitive_string.go Show resolved Hide resolved
internal/security/sensitive_string.go Outdated Show resolved Hide resolved
internal/security/sensitive_string.go Outdated Show resolved Hide resolved
@igor-sirotin igor-sirotin merged commit ef177c1 into develop Dec 11, 2024
18 checks passed
@igor-sirotin igor-sirotin deleted the feat/sensitive-string branch December 11, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SensitiveString type
4 participants