Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add wasm support for blas/base/cswap-wasm #3211

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: add wasm support for blas/base/cswap-wasm #3211

merged 2 commits into from
Nov 21, 2024

Conversation

aman-095
Copy link
Member

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request adds wasm support for cswap.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 21, 2024
@aman-095 aman-095 added Feature Issue or pull request for adding a new feature. WebAssembly Issue involves or relates to WebAssembly. labels Nov 21, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 21, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/base/cswap-wasm $\color{green}844/844$
$\color{green}+100.00\%$ 		$\color{green}17/17$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}844/844$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@aman-095 aman-095 marked this pull request as ready for review November 21, 2024 09:33
kgryte
kgryte approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

You should also see the changes that I made in case any are applicable to other and future PRs. Cheers!

@kgryte kgryte merged commit 493db03 into stdlib-js:develop Nov 21, 2024
11 checks passed
pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 25, 2024
@aman-095 @kgryte @pranav-1720
feat: add blas/base/cswap-wasm
57a7009 
PR-URL: stdlib-js#3211
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
@aman-095 @kgryte @Neerajpathak07
feat: add blas/base/cswap-wasm
7fc9882 
PR-URL: stdlib-js#3211
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. WebAssembly Issue involves or relates to WebAssembly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-095 @stdlib-bot @kgryte