EFX spawnarg for location entities #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgatilov
reviewed
Jun 6, 2024
sound/snd_efxfile.cpp
Outdated
| effects.Append(soundEffect); | ||
| } | ||
| else { | ||
| ok = AddPreset(efxPreset, soundEffect, err); |
There was a problem hiding this comment.
I don't understand why both cases call AddPreset.
There was a problem hiding this comment.
Presets can be used by either the EFX file or the spawnarg, so instead of duplicating the code I refactored it into a new function.
There was a problem hiding this comment.
Sorry ignore my last comment - I understand what you mean now. I've gone back and refactored it, it should look better now.
| efxf(AL_EAXREVERB_ROOM_ROLLOFF_FACTOR, props->flRoomRolloffFactor); | ||
| efxi(AL_EAXREVERB_DECAY_HFLIMIT, props->iDecayHFLimit); | ||
|
|
||
| } |
MayaImport.vcxproj.user
Outdated
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup /> | ||
| </Project> |
There was a problem hiding this comment.
This file should not be added to VCS I suppose.
|
I merged this as svn rev 10797. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to specify EFX preset as a spawnarg on location entities.
Test map here (efxtest.map): https://github.com/FrostSalamander/dev-test-maps/tree/main