-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md + Add support for Markdown/HTML + Update loop targets #10
Open
sheriffMoose
wants to merge
9
commits into
storybookjs:next
Choose a base branch
from
sheriffMoose:next
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter the elements that goes into the loop to work with `Meta` elements only instead of all elements
allows extracting `title` from `.md` & `.html` docs via the `<title></title>` element
add getting started info + more details about the output
missing feature that is supposed to exist as it is being called already in StoryIndexGenerator
sheriffMoose
added
documentation
Changes only affect the documentation
enhancement
New feature or request
maintenance
labels
Jan 19, 2023
shilman
reviewed
Jan 26, 2023
Co-authored-by: Michael Shilman <[email protected]>
Co-authored-by: Michael Shilman <[email protected]>
…/html title processing
@sheriffMoose @shilman Hi! Any plan to approve/merge this? Would love to be able to set tags on unattached docs, since i cannot seem to find any other way to do that without this! Thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What Changed
<title>
tag.tags
(was supposed to be there as it is already being referenced inStoryIndexGenerator.ts
.analyze
loop to target onlyMeta
elements instead of all elements.How to test
Change Type
maintenance
documentation
minor