Link Cvc & Expiry recollection #9880
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
47
to
51
| get() = true | ||
| // get() = !DateUtils.isExpiryDataValid( | ||
| // expiryMonth = expiryMonth, | ||
| // expiryYear = expiryYear | ||
| // ) |
There was a problem hiding this comment.
The isExpired property appears to be hardcoded to true for testing purposes, with the actual expiry validation logic commented out. This will cause all cards to be treated as expired in production. The original validation using DateUtils.isExpiryDataValid() should be uncommented and restored to ensure correct expiry checking behavior.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
Diffuse output: APKDEX |
| @@ -23,7 +30,11 @@ internal data class WalletUiState( | |||
| val isExpired = card?.isExpired ?: false | |||
| val requiresCvcRecollection = card?.cvcCheck?.requiresRecollection ?: false | |||
|
|
|||
| val disableButton = isExpired || requiresCvcRecollection | |||
| val isMissingExpiryDateInput = (expiryDateInput.isComplete && cvcInput.isComplete).not() | |||
There was a problem hiding this comment.
The isMissingExpiryDateInput check should only depend on expiryDateInput.isComplete. Including cvcInput.isComplete in this check is incorrect since it's meant to validate expiry date completeness only. The check should be simplified to:
val isMissingExpiryDateInput = expiryDateInput.isComplete.not()Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
expired cards requires both updated expiryDate and cvc
toluo-stripe
force-pushed
the
tolu/link/cvc_expiry
branch
from
3af6c2f to
08ac506
Compare
Comment on lines
143
to
169
| private suspend fun performPaymentConfirmation( | ||
| selectedPaymentDetails: ConsumerPaymentDetails.PaymentDetails, | ||
| ) { | ||
| val card = _uiState.value.selectedCard | ||
| val isExpired = card != null && card.isExpired | ||
|
|
||
| if (isExpired) { | ||
| performPaymentDetailsUpdate(selectedPaymentDetails).fold( | ||
| onSuccess = { result -> | ||
| val updatedPaymentDetails = result.paymentDetails.single { | ||
| it.id == selectedPaymentDetails.id | ||
| } | ||
| performPaymentConfirmation(updatedPaymentDetails) | ||
| }, | ||
| onFailure = { error -> | ||
| _uiState.update { | ||
| it.copy( | ||
| alertMessage = error.stripeErrorMessage(), | ||
| isProcessing = false | ||
| ) | ||
| } | ||
| } | ||
| ) | ||
| } | ||
|
|
||
| // Confirm payment with LinkConfirmationHandler | ||
| } |
There was a problem hiding this comment.
The performPaymentConfirmation method needs a return statement after the if (isExpired) block to prevent executing the payment confirmation logic twice. Currently, if a card is expired, the method will both update the card details and attempt to confirm the payment in the same call, which could lead to duplicate transactions.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
toluo-stripe
force-pushed
the
tolu/link/cvc_expiry
branch
from
08ac506 to
ca44972
Compare
Comment on lines
+224
to
+231
| private fun WalletUiState.toPaymentMethodCreateParams(): PaymentMethodCreateParams { | ||
| val expiryDateValues = createExpiryDateFormFieldValues(expiryDateInput) | ||
| return FieldValuesToParamsMapConverter.transformToPaymentMethodCreateParams( | ||
| fieldValuePairs = expiryDateValues, | ||
| code = PaymentMethod.Type.Card.code, | ||
| requiresMandate = false | ||
| ) | ||
| } |
There was a problem hiding this comment.
The toPaymentMethodCreateParams() function appears incomplete - it transforms the expiry date but omits the CVC value from cvcInput. Both values should be included in the fieldValuePairs map passed to transformToPaymentMethodCreateParams() to properly validate the card details.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
cvc is not part of PaymentMethodCreateParams. It will be passed extraParams to the LinkConfirmationHandler` here
toluo-stripe
commented
Jan 9, 2025
| } | ||
| ) | ||
| } else { | ||
| // Confirm payment with LinkConfirmationHandler |
There was a problem hiding this comment.
toluo-stripe
commented
Jan 9, 2025
|
|
||
| onWalletAddPaymentMethodRow().assertIsDisplayed().assertHasClickAction() | ||
| onExpandedWalletHeader().assertIsDisplayed() | ||
| onPaymentMethodList().assertCountEquals(2) | ||
| onWalletPayButton().assertIsDisplayed().assertIsNotEnabled().assertHasClickAction() |
There was a problem hiding this comment.
Pay button is hidden on Android for small devices, when the wallet is expanded. I created a ticket to resolve this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Perform cvc recollection and collect updated expiry date for expired cards
Motivation
JIRA
Testing
Screenshots
Screen.Recording.2025-01-09.at.1.50.06.AM.mov
Changelog