-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Wall of Love page #45
Conversation
This is great! 😍 Four nitpicky comments:
|
@alfonsogoberjr I have similar suggestions, as @mxstbr's 😄
Optimally we'd want our tweets to be hardcoded or fetched in
We'll have to add a navigation menu bar at the top now, since I think that's the cleanest way to deal with the future pages that we'll add. If you'd like to do this, @alfonsogoberjr, I can create a quick design for you :) Another thing is, once we have a navigation menu, the header of this page should not include the text, logo and so on at the top. Also the content should be displayed on a white background. The footer should also look the same as on the homepage. Basically the content should be presented in the same way, as it is presented on the homepage. With the same title and text style. The navigation bar is sth that we can also add in a separate PR first 😄 |
@alfonsogoberjr I'll try to get a design ready for you, but I think the menu-bar should be done separately maybe. Not sure if you meant that you're interested in doing this task as well? |
@philpl I agree the menu-bar should be done separately, but either way I prefer to do front-end work based on mockups, so whichever you want to make them for first, I'm happy to work on. |
Btw thanks for all the feedback! 😄 |
Are you working on it? |
@morajabi @alfonsogoberjr need any help here? |
@mckernanin @morajabi Still blocked pending mockups from @kitten or any other styled-components site designer |
Made the Wall of Love page with this list of tweets. Accessible at
/wall-of-love
, there is also a button on the homepage and a clickable logo on the Wall of Love to take you back to/
.Feel free to recommend any design changes, I simply used the pink gradient background from the homepage and included the footer for consistency.
Cheers