Add IdentfyingLabels to CreateOrUpdateWithOptions #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the GenerateName field is set in the target resource, the existing resource is searched for by the target's labels. However this assumes the labels remain static for the lifetime of the resource. If the labels are updated then the existing resource is not found and a new one is created. To avoid this, allow the user to specify which labels uniquely identify the resource by adding an IdentfyingLabels field to CreateOrUpdateOptions. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1001/tpantelis/create_or_update_labels |
yboaron
approved these changes
Oct 7, 2024
skitt
approved these changes
Oct 7, 2024
|
🤖 Closed branches: [z_pr1001/tpantelis/create_or_update_labels] |
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the GenerateName field is set in the target resource, the existing resource is searched for by the target's labels. However this assumes the labels remain static for the lifetime of the resource. If the labels are updated then the existing resource is not found and a new one is created. To avoid this, allow the user to specify which labels uniquely identify the resource by adding an
IdentfyingLabelsfields toCreateOrUpdateOptions.Related to submariner-io/lighthouse#1646