Fix arch detection of Linux/aarch64 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
requested review from
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr59/nirs/aarch64 |
|
Example run: |
Fix arch detection on Linux/aarch64 (e.g. Asahi Linux on MacBook M*).
From Go point of view, this is arm64.
$ uname -m
aarch64
$ go env GOOS
linux
$ go env GOARCH
arm64
Tested by running directly from source.
Fixes submariner-io#58
Signed-off-by: Nir Soffer <[email protected]>
skitt
approved these changes
Feb 22, 2024
dfarrell07
approved these changes
Feb 27, 2024
|
🤖 Closed branches: [z_pr59/nirs/aarch64] |
|
Thanks for the PR @nirs! |
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Mar 12, 2024
Release note for submariner-io/get.submariner.io#59 This isn't tied to an actual release but it most closely coincides with the 0.17 release. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Mar 18, 2024
Release note for submariner-io/get.submariner.io#59 This isn't tied to an actual release but it most closely coincides with the 0.17 release. Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix arch detection on Linux/aarch64 (e.g. Asahi Linux on MacBook M*). From Go point of view, this is arm64.
Tested by running directly from source.
Fixes #58