Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update K8s versions tested in E2E #1445

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Conversation

dfarrell07
Copy link
Member

@dfarrell07 dfarrell07 commented Nov 20, 2023

Add Kubernetes 1.26 and 1.28, remove end-of-life 1.22-1.25.

Add K8s 1.21, the oldest working version for Service Discovery.

Per discussions, only test ends of supported K8s version range. Don't
test versions in the middle of the range to avoid GHA runs that don't
add useful coverage.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1445/dfarrell07/k8s_128
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@dfarrell07 dfarrell07 added the ready-to-test When a PR is ready for full E2E testing label Nov 20, 2023
@dfarrell07
Copy link
Member Author

Go Unit Tests failed, re-running.

@dfarrell07
Copy link
Member Author

Go Unit Tests failed, re-running.

Passing now

Copy link

github-actions bot commented Dec 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 6, 2023
@dfarrell07 dfarrell07 force-pushed the k8s_128 branch 2 times, most recently from 1fd0320 to 544cf51 Compare December 11, 2023 15:45
@github-actions github-actions bot removed the stale label Dec 12, 2023
Add Kubernetes 1.26 and 1.28, remove end-of-life 1.22-1.25.

Add K8s 1.21, the oldest working version for Service Discovery.

Per discussions, only test ends of supported K8s version range. Don't
test versions in the middle of the range to avoid GHA runs that don't
add useful coverage.

Signed-off-by: Daniel Farrell <[email protected]>
@tpantelis tpantelis enabled auto-merge (rebase) December 12, 2023 12:56
@tpantelis
Copy link
Contributor

The E2E for K8s 1.21 where we change the backing pods fails. dig returns duplicate IPs which doesn't affect verification of discovered IPs b/c we check for string containment but it does affect the case where we expect no IPs. I think doing #1322 should alleviate this issue. It seems the behavior of EndpointSlices in 1.21 is a bit different that later versions.

@tpantelis
Copy link
Contributor

The E2E for K8s 1.21 where we change the backing pods fails. dig returns duplicate IPs which doesn't affect verification of discovered IPs b/c we check for string containment but it does affect the case where we expect no IPs. I think doing #1322 should alleviate this issue. It seems the behavior of EndpointSlices in 1.21 is a bit different that later versions.

It actually turned out to be a bug in the production code. #1457 fixes it.

@tpantelis tpantelis merged commit c88fbf5 into submariner-io:devel Dec 15, 2023
23 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1445/dfarrell07/k8s_128]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants