Skip to content

Commit

Permalink
Remove use of deprecated KubeProxyVersion field
Browse files Browse the repository at this point in the history
...in NodeSystemInfo. It's deprecated because "the value of this
field wasn't (and isn't) accurate". We only show it in the gather
summary so remove it.

Signed-off-by: Tom Pantelis <[email protected]>
  • Loading branch information
tpantelis committed Aug 21, 2024
1 parent 9709b95 commit 730df5e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
2 changes: 0 additions & 2 deletions internal/gather/layout.gohtml
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,13 @@
<tr>
<th style="width: 15%;">Node name</th>
<th style="width: 30%;">Operating System</th>
<th style="width: 15%;">KubeProxy Version</th>
<th style="width: 15%;">Internal IP</th>
<th style="width: 15%;">External IP</th>
</tr>
{{range .NodeConfig}}
<tr>
<td>{{.Name}}</td>
<td>{{.Info.OperatingSystem}} {{.Info.OSImage}} {{.Info.KernelVersion}} {{.Info.Architecture}}</td>
<td>{{.Info.KubeProxyVersion}}</td>
<td>{{.InternalIPs}}</td>
<td>{{.ExternalIPs}}</td>
</tr>
Expand Down
9 changes: 4 additions & 5 deletions internal/gather/summary.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,10 @@ func getNodeConfig(info *Info) ([]nodeConfig, error) {
for i := range nodes.Items {
node := &nodes.Items[i]
nodeInfo := v1.NodeSystemInfo{
KernelVersion: node.Status.NodeInfo.KernelVersion,
OSImage: node.Status.NodeInfo.OSImage,
KubeProxyVersion: node.Status.NodeInfo.KubeProxyVersion,
OperatingSystem: node.Status.NodeInfo.OperatingSystem,
Architecture: node.Status.NodeInfo.Architecture,
KernelVersion: node.Status.NodeInfo.KernelVersion,
OSImage: node.Status.NodeInfo.OSImage,
OperatingSystem: node.Status.NodeInfo.OperatingSystem,
Architecture: node.Status.NodeInfo.Architecture,
}
name := node.GetName()
config := nodeConfig{
Expand Down

0 comments on commit 730df5e

Please sign in to comment.