Allow overriding the broker API endpoint URL #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deploy-broker doesn't have any sub-commands, flags shouldn't be persistent. Signed-off-by: Stephen Kitt <[email protected]>
skitt
requested review from
Jaanki,
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr1017/skitt/override-broker-url |
In some setups, the broker URL determined from the kubeconfig context isn't usable from the clusters which will be joined. For these setups, the broker URL needs to be overridden, and this implements that by adding a --broker-url option to the following subctl sub-commands: * deploy-broker, to override the URL stored in the generated broker-info.subm file * recover-broker-info, for the same reason * join, to override the URL retrieved from the broker-info.subm file Thus when the user knows ahead of time that the broker URL needs to be manually specified, they can provide the correct setting to deploy-broker, and join works as before. If they didn't know when deploy-broker was run, they can specify the correct URL when joining clusters. This also handles setups where each joining cluster might need a different URL to reach the broker. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
override-broker-url
branch
from
43974a5 to
9ba3464
Compare
tpantelis
approved these changes
Dec 1, 2023
dfarrell07
approved these changes
Dec 4, 2023
|
🤖 Closed branches: [z_pr1017/skitt/override-broker-url] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some setups, the broker URL determined from the kubeconfig context isn't usable from the clusters which will be joined. For these setups, the broker URL needs to be overridden, and this implements that by adding a --broker-url option to the following subctl sub-commands:
Thus when the user knows ahead of time that the broker URL needs to be manually specified, they can provide the correct setting to deploy-broker, and join works as before. If they didn't know when deploy-broker was run, they can specify the correct URL when joining clusters. This also handles setups where each joining cluster might need a different URL to reach the broker.
Fixes: #300