Use global clusterset IP enabled flag on join #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
aswinsuryan,
dfarrell07,
Jaanki,
maayanf24,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1234/tpantelis/use_cluster_ip_enabled |
5 tasks
vthapar
approved these changes
Sep 30, 2024
maayanf24
approved these changes
Sep 30, 2024
|
This PR/issue depends on: |
Use the enabled flag return from clustersetip.AllocateCIDRFromConfigMap to set the Submariner.ClustersetIPEnabled flag. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
use_cluster_ip_enabled
branch
from
fc0e4b3 to
9cd4f0e
Compare
|
🤖 Closed branches: [z_pr1234/tpantelis/use_cluster_ip_enabled] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the enabled flag return from
clustersetip.AllocateCIDRFromConfigMapto set theSubmariner.ClustersetIPEnabledflag.Depends on submariner-io/submariner-operator#3234