Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand system tests to cover all join flags #2373

Open
dfarrell07 opened this issue Nov 29, 2022 · 5 comments
Open

Expand system tests to cover all join flags #2373

dfarrell07 opened this issue Nov 29, 2022 · 5 comments

Comments

@dfarrell07
Copy link
Member

Some flags, like the cable driver, are currently not covered by system tests.

https://github.com/submariner-io/submariner-operator/blob/devel/scripts/test/system.sh

Look into flags that we set via join and expect a result in K8s objects, verify at a system test level they are actually set.

@stale
Copy link

stale bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 2, 2023
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Apr 4, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 17, 2023
@dfarrell07 dfarrell07 added priority:low and removed wontfix This will not be worked on labels Nov 14, 2023
@tpantelis
Copy link
Contributor

I think this would be suitable for unit tests.

@tpantelis tpantelis self-assigned this Feb 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 10, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Backlog Oct 15, 2024
@dfarrell07 dfarrell07 removed the stale label Oct 15, 2024
@tpantelis tpantelis moved this from Backlog to Next Version Candidate in Backlog Oct 28, 2024
@maayanf24 maayanf24 removed this from Backlog Oct 29, 2024
@maayanf24 maayanf24 moved this to Todo in Submariner 0.20 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants