Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate replicasets RBAC #2339

Closed
wants to merge 1 commit into from
Closed

Remove duplicate replicasets RBAC #2339

wants to merge 1 commit into from

Conversation

dfarrell07
Copy link
Member

@dfarrell07 dfarrell07 commented Nov 11, 2022 •
edited
Loading

The RBAC for replicasets duplicates the get permission, as it's granted * elsewhere.

Signed-off-by: Daniel Farrell [email protected]

@dfarrell07
Remove duplicate replicasets RBAC
ada2aaa 
The RBAC for replicasets duplicates the get permission, as it's granted
* elsewhere.

Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 requested a review from Oats87 as a code owner November 11, 2022 14:59
@dfarrell07 dfarrell07 self-assigned this Nov 11, 2022
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2339/dfarrell07/repset_rbac
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Nov 15, 2022
@skitt
Copy link
Member

skitt commented Dec 7, 2022

I would rather go the other way, move to explicit permissions rather than blanket permissions. Ideally this would be generated from code, but perhaps that’s hidden next to the leprechauns at the base of a rainbow somewhere.

@stale
Copy link

stale bot commented Dec 23, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 23, 2022
@sridhargaddam sridhargaddam removed the wontfix This will not be worked on label Dec 26, 2022
@stale
Copy link

stale bot commented Jan 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 10, 2023
@dfarrell07
Copy link
Member Author

Closing in favor of #1105

@dfarrell07 dfarrell07 closed this Jan 10, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2339/dfarrell07/repset_rbac]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees

@dfarrell07 dfarrell07

Labels
ready-to-test When a PR is ready for full E2E testing wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dfarrell07 @submariner-bot @skitt @tpantelis @sridhargaddam