Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HaltOnCertificateError optional #2863

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

skitt
Copy link
Member

@skitt skitt commented Oct 31, 2023

... to simplify upgrades. This is the safe option: the value defaults to false, so existing setups keep their current behaviour.

... to simplify upgrades. This is the safe option: the value defaults
to false, so existing setups keep their current behaviour.

Signed-off-by: Stephen Kitt <[email protected]>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2863/skitt/optional-halt-cert-error
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@skitt skitt added the backport This change requires a backport to eligible release branches label Oct 31, 2023
@tpantelis tpantelis enabled auto-merge (rebase) October 31, 2023 17:09
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Oct 31, 2023
@tpantelis tpantelis merged commit 18213b3 into submariner-io:devel Oct 31, 2023
47 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2863/skitt/optional-halt-cert-error]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This change requires a backport to eligible release branches backport-handled ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants