Automated backport of #3040: Reduce submariner-operator RBAC permissions #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Role wildcard access to "pods" - only "get" and "list" access is needed which is provided by the ClusterRole. - "services" are created for metrics so reduce Role access accordingly - The operator does not access "endpoints", "persistentvolumeclaims", "events", "replicasets" or "statefulsets" so remove access. - Reduce access to "deployments", "daemonsets" and "submariner.io" resources to only what's needed and remove wildcard access. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr3049/tpantelis/automated-backport-of-#3040-upstream-release-0.15 |
tpantelis
force-pushed
the
automated-backport-of-#3040-upstream-release-0.15
branch
from
423cfec to
adcd4ab
Compare
tpantelis
requested review from
aswinsuryan,
dfarrell07,
maayanf24 and
yboaron
as code owners
tpantelis
force-pushed
the
automated-backport-of-#3040-upstream-release-0.15
branch
from
adcd4ab to
ad6cc22
Compare
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
May 6, 2024
Release notes for submariner-io/submariner-operator#3049 Signed-off-by: Tom Pantelis <[email protected]>
dfarrell07
approved these changes
May 6, 2024
tpantelis
force-pushed
the
automated-backport-of-#3040-upstream-release-0.15
branch
from
ad6cc22 to
d8d0855
Compare
- The following resources are not accessed at all so remove permissions: - "services" - "endpoints" - "events" - "configmaps" - "deployments" - "daemonsets" - "replicasets" - "statefulsets" - "customresourcedefinitions", - "operator.openshift.io/dnses" - "config.openshift.io/networks" - "monitoring.coreos.com/servicemonitors" - The gateway pod is annotated - it only needs "get" and "update" access - Remove wildcard access to "submariner.io" resources and specify exactly what's needed. - Reduce "configmaps" access to just "get". Signed-off-by: Tom Pantelis <[email protected]>
- The following resources are not accessed so remove permissions: - "services" - "endpoints" - "events" - "deployments" - "daemonsets" - "replicasets" - "statefulsets" - "customresourcedefinitions", - "operator.openshift.io/dnses" - "monitoring.coreos.com/servicemonitors" - Reduce access to "pods", "services", "secrets", "configmaps", and "endpoints" to "get" and "list" - Remove wildcard access to "submariner.io" resources and specify exactly what's needed. Signed-off-by: Tom Pantelis <[email protected]>
- The following resources are not accessed at all so remove permissions: - "services" - "endpoints" - "persistentvolumeclaims" - "events" - "configmaps" - "secrets" - "deployments" - "daemonsets" - "replicasets" - "statefulsets" - "namespaces" - "monitoring.coreos.com/servicemonitors" - Reduce "pods" access to only "get", "list", "watch" Signed-off-by: Tom Pantelis <[email protected]>
- Remove "update" access to "services", "namespaces" and "endpoints". - Remove wildcard access to "multicluster.x-k8s.io" resources and specify exactly what's needed. Signed-off-by: Tom Pantelis <[email protected]>
- The following resources are not accessed so remove permissions: - "services" - "endpoints" - "namespaces" - Reduce "endpointslices" access to "get", "list", and "watch" Signed-off-by: Tom Pantelis <[email protected]>
We grant namespace read permissions which is only needed to query for the existence of the "openshift-monitoring" namespace to determine where to create ServiceMonitors. However we can eliminate this query and thus the permissions by trying to create ServiceMonitors in the "openshift-monitoring" namespace and, if the error indicates the namespace is missing, create in the provided namespace. Signed-off-by: Tom Pantelis <[email protected]>
This resource type is only used for network settings discovery to query the "cluster" Network so restrict the RBAC to only "get" access to the "cluster" resource name. This applies to both the submariner-operator: https://github.com/submariner-io/submariner/blob/85fea596f30b0e84d6962c92bb129a6b8bce8028/pkg/routeagent_driver/handlers/ovn/connection.go#L358 and route-agent components: https://github.com/submariner-io/submariner/blob/85fea596f30b0e84d6962c92bb129a6b8bce8028/pkg/routeagent_driver/handlers/ovn/connection.go#L358 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
automated-backport-of-#3040-upstream-release-0.15
branch
from
d8d0855 to
ebcae2e
Compare
|
I'll backport #3050 with this PR - setting as draft for now. |
Use "openshiftMonitoringNS" instead of "ns" when first attempting to create in the former namespace. Signed-off-by: Tom Pantelis <[email protected]>
CRUD access to Secrets were removed but it turns out we need it in order to sync Secrets from the broker namespace to the submariner-operator namespace. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
automated-backport-of-#3040-upstream-release-0.15
branch
from
ebcae2e to
d637dd4
Compare
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
automated-backport-of-#3040-upstream-release-0.15
branch
from
d637dd4 to
c021745
Compare
dfarrell07
approved these changes
May 7, 2024
|
🤖 Closed branches: [z_pr3049/tpantelis/automated-backport-of-#3040-upstream-release-0.15] |
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
May 9, 2024
Release notes for submariner-io/submariner-operator#3049 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jun 27, 2024
Release notes for submariner-io/submariner-operator#3049 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Jun 28, 2024
Release notes for submariner-io/submariner-operator#3049 Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3040 on release-0.15.
#3040: Reduce submariner-operator RBAC permissions
For details on the backport process, see the backport requests page.