Add YAML linting, fix errors

Signed-off-by: Daniel Farrell <[email protected]>

.github/stale.yml

@@ -1,6 +1,7 @@
+---
 # Configuration for probot-stale - https://github.com/probot/stale
 
-# Number of days of inactivity before an Issue becomes stale (pull request is overridden later) 
+# Number of days of inactivity before an Issue becomes stale (pull request is overridden later)
 daysUntilStale: 120
 
 # Number of days of inactivity before an Issue or Pull Request with the stale label is closed.
@@ -49,8 +50,8 @@ limitPerRun: 30
 # only: issues
 
 pulls:
-   daysUntilStale: 30
-   markComment: >
-     This pull request has been automatically marked as stale because it has not had
-     recent activity. It will be closed if no further activity occurs. Thank you
-     for your contributions.
+  daysUntilStale: 30
+  markComment: >
+    This pull request has been automatically marked as stale because it has not had
+    recent activity. It will be closed if no further activity occurs. Thank you
+    for your contributions.

.github/workflows/dco-check.yml

@@ -1,3 +1,4 @@
+---
 name: DCO Check
 on: pull_request
 
@@ -6,12 +7,12 @@ jobs:
     runs-on: ubuntu-latest
     name: DCO Check
     steps:
-    - name: Get PR Commits
-      id: 'get-pr-commits'
-      uses: tim-actions/get-pr-commits@master
-      with:
-        token: ${{ secrets.GITHUB_TOKEN }}
-    - name: DCO Check
-      uses: tim-actions/dco@master
-      with:
-        commits: ${{ steps.get-pr-commits.outputs.commits }}
+      - name: Get PR Commits
+        id: 'get-pr-commits'
+        uses: tim-actions/get-pr-commits@master
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+      - name: DCO Check
+        uses: tim-actions/dco@master
+        with:
+          commits: ${{ steps.get-pr-commits.outputs.commits }}

.github/workflows/e2e.yaml → .github/workflows/e2e.yml

@@ -1,3 +1,4 @@
+---
 on:
   pull_request:
   push:
@@ -18,7 +19,7 @@ jobs:
         deploytool: ['operator', 'helm']
         cable_driver: ['', 'wireguard', 'libreswan']
         exclude:
-# Our Helm setup doesn’t know how to deploy other cable drivers
+          # Our Helm setup doesn’t know how to deploy other cable drivers
           - deploytool: 'helm'
             cable_driver: 'wireguard'
           - deploytool: 'helm'
@@ -35,7 +36,8 @@ jobs:
           sudo apt install -y linux-headers-$(uname -r) wireguard wireguard-dkms
           if [[ "$(uname -r)" =~ -1020- ]]; then
             # the 1020 kernel doesn't have skb_reset_redirect in skbuff.h, patch Wireguard so it doesn't need it
-            curl https://git.zx2c4.com/wireguard-linux/patch/drivers/net/wireguard/queueing.h\?id=2c64605b590edadb3fb46d1ec6badb49e940b479 | sudo patch -R /usr/src/wireguard*/queueing.h
+            curl https://git.zx2c4.com/wireguard-linux/patch/drivers/net/wireguard/queueing.h\?id=2c64605b590edadb3fb46d1ec6badb49e940b479 \
+              | sudo patch -R /usr/src/wireguard*/queueing.h
             sudo dpkg-reconfigure wireguard-dkms
           fi
           sudo modprobe wireguard

.github/workflows/gitlint.yaml → .github/workflows/gitlint.yml

@@ -1,3 +1,4 @@
+---
 on:
   pull_request:
   push:

.github/workflows/md-links-periodic.yml

@@ -1,3 +1,4 @@
+---
 name: Markdown Link Checks
 on:
   schedule:
@@ -8,18 +9,18 @@ jobs:
     runs-on: ubuntu-latest
     name: Markdown Link Checks
     steps:
-    - name: Check out code
-      uses: actions/checkout@v1
+      - name: Check out code
+        uses: actions/checkout@v1
 
-    - name: Run markdown-link-check
-      uses: gaurav-nelson/[email protected]
-      with:
-        config-file: ".markdownlinkcheck.json"
+      - name: Run markdown-link-check
+        uses: gaurav-nelson/[email protected]
+        with:
+          config-file: ".markdownlinkcheck.json"
 
-    - name: Raise an Issue to report broken links
-      if: ${{ failure() }}
-      uses: JasonEtco/create-an-issue@v2
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      with:
-        filename: .github/ISSUE_TEMPLATE/broken-link.md
+      - name: Raise an Issue to report broken links
+        if: ${{ failure() }}
+        uses: JasonEtco/create-an-issue@v2
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          filename: .github/ISSUE_TEMPLATE/broken-link.md

.github/workflows/md-links.yml

@@ -1,3 +1,4 @@
+---
 name: Markdown Link Checks
 on: pull_request
 
@@ -6,11 +7,11 @@ jobs:
     runs-on: ubuntu-latest
     name: Markdown Link Checks
     steps:
-    - name: Check out code
-      uses: actions/checkout@v1
+      - name: Check out code
+        uses: actions/checkout@v1
 
-    - name: Run markdown-link-check
-      uses: gaurav-nelson/[email protected]
-      with:
-        config-file: ".markdownlinkcheck.json"
-        check-modified-files-only: "yes"
+      - name: Run markdown-link-check
+        uses: gaurav-nelson/[email protected]
+        with:
+          config-file: ".markdownlinkcheck.json"
+          check-modified-files-only: "yes"

.github/workflows/release.yaml → .github/workflows/release.yml

@@ -1,3 +1,4 @@
+---
 on:
   push:
     branches:

.github/workflows/validation.yml

@@ -1,3 +1,4 @@
+---
 on:
   pull_request:
     branches:

.github/workflows/yaml-lint.yml

@@ -0,0 +1,17 @@
+---
+name: YAML Linting
+on: pull_request
+
+jobs:
+  yaml-lint:
+    runs-on: ubuntu-latest
+    name: YAML Linting
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v1
+
+      - name: Run yamllint
+        uses: ibiqlik/action-yamllint@v1
+        with:
+          file_or_dir: .
+          config_file: .yamllint.yml

.golangci.yml

@@ -1,3 +1,4 @@
+---
 linters-settings:
   gocritic:
     enabled-tags:
@@ -20,17 +21,17 @@ linters:
     - bodyclose
     - deadcode
     - depguard
-    #- dupl
+    # - dupl
     - errcheck
     - exportloopref
-    #- funlen
-    #- gochecknoglobals
-    #- gochecknoinits
+    # - funlen
+    # - gochecknoglobals
+    # - gochecknoinits
     - gocritic
     - gocyclo
     - gofmt
     - goimports
-    #- golint
+    # - golint
     - gosec
     - gosimple
     - govet
@@ -42,8 +43,8 @@ linters:
     - nakedret
     - staticcheck
     - structcheck
-    #- stylecheck
-    #- testpackage
+    # - stylecheck
+    # - testpackage
     - typecheck
     - unconvert
     - unparam

.markdownlint.yml

@@ -1,3 +1,4 @@
+---
 # Breaks reusing MD snippets extracted to files
 first-line-heading: false
 

.yamllint.yml

@@ -0,0 +1,14 @@
+---
+extends: default
+
+rules:
+  line-length:
+    max: 140
+  # Allow standard GHA syntax for "on: *"
+  truthy:
+    ignore: '.github/workflows/*.yml'
+
+ignore: |
+  /vendor
+
+strict: true

tools/openshift/ocp-ipi-aws/ocp-ipi-aws-prep/templates/machine-set.yaml

@@ -1,3 +1,4 @@
+---
 apiVersion: machine.openshift.io/v1beta1
 kind: MachineSet
 metadata: