Automated backport of #2772: Only update local Endpoint when setting HealthCheckIP #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr2773/tpantelis/automated-backport-of-#2772-upstream-release-0.16 |
When setting the HealthCheckIP from the Node global IP, it was doing a create-or-update operation but we really want to just update. It was observed in a leader election fail-over scenario where a local Endpoint was recreated on Node update after the Endpoint had been deleted, which caused issues (see https://issues.redhat.com/browse/ACM-8274). Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
automated-backport-of-#2772-upstream-release-0.16
branch
from
a696056 to
442862d
Compare
nyechiel
approved these changes
Oct 28, 2023
sridhargaddam
approved these changes
Oct 28, 2023
|
🤖 Closed branches: [z_pr2773/tpantelis/automated-backport-of-#2772-upstream-release-0.16] |
tpantelis
deleted the
automated-backport-of-#2772-upstream-release-0.16
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2772 on release-0.16.
#2772: Only update local Endpoint when setting HealthCheckIP
For details on the backport process, see the backport requests page.