Exclude code from SonarCloud analysis #2809
Conversation
tpantelis
commented
Nov 22, 2023
tpantelis
commented
- Generated code
- Test support
- External library wrappers
- Generated code - Test support - External library wrappers Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr2809/tpantelis/sonar_exclude |
| @@ -2,7 +2,7 @@ sonar.projectKey=submariner-io_submariner | |||
| sonar.projectName=submariner | |||
| sonar.organization=submariner-io | |||
| sonar.sources=. | |||
| sonar.exclusions=**/vendor/**,**/*_test.go,**/test/**,**/fake/**,**/client/** | |||
| sonar.exclusions=**/vendor/**,**/*_test.go,**/test/**,**/fake/**,**/client/**,**/natdiscovery/proto/natdiscovery.pb.go,**/netlink/**,**/event/testing/**,**/zz_generated.deepcopy.go,**/ipset/** | |||
There was a problem hiding this comment.
Is the removal of ipset and netlink packages intentional?
There was a problem hiding this comment.
IIUC, yes, because they are external library wrappers.
There was a problem hiding this comment.
Not all APIs are passthrough, we have some APIs implemented. Do we want to avoid sonar on them?
There was a problem hiding this comment.
netlink is a straight pass-through. ipset is not our code - we copied it from somewhere. There might be some helper methods we could unit test but I don't think it's necessary. I think the E2E tests it sufficiently, at least the code we use. @sridhargaddam What API are you specifically concerned about?
There was a problem hiding this comment.
Actually, FWICT, virtually all helpers, eg validate*, are private.
There was a problem hiding this comment.
Right, there are few APIs like Create/Add/Del/Destroy etc, but the code is pretty much stable and has not undergone any major changes, so we can skip it. I wanted to confirm that we did not accidentally remove them.
|
🤖 Closed branches: [z_pr2809/tpantelis/sonar_exclude] |
