Construct package dependencies using Go #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
mkolesnik,
Oats87,
sridhargaddam,
tpantelis,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr3239/skitt/pkgdeps |
dfarrell07
reviewed
Dec 4, 2024
dfarrell07
approved these changes
Dec 4, 2024
tpantelis
approved these changes
Dec 11, 2024
| pkgdeps = $(shell find $$(go list -json $(1) | jq -r '.Imports[] | select(startswith("$(basepkg)")) | sub("$(basepkg)"; ".")') -name '*.go' -not -name '*_test.go') | ||
|
|
||
| # natdiscovery.pb.go must be listed explicitly because it might not exist when Make evaluates pkgdeps | ||
| bin/%/submariner-gateway: main.go $(call pkgdeps,.) pkg/natdiscovery/proto/natdiscovery.pb.go |
There was a problem hiding this comment.
Should this be?
Suggested change
| bin/%/submariner-gateway: main.go $(call pkgdeps,.) pkg/natdiscovery/proto/natdiscovery.pb.go | |
| bin/%/submariner-gateway: main.go $(call pkgdeps,./pkg/gateway) pkg/natdiscovery/proto/natdiscovery.pb.go |
There was a problem hiding this comment.
The root of the dependency tree is the package containing the main file, so . in this case. However while investigating this comment I realised that .Imports[] only contains first-level imports, and the pkgdeps macro really needs to look at .Deps[] instead…
There was a problem hiding this comment.
Note too how the argument to pkgdeps matches the argument to compile.sh 😉
For best results, Make should be told about all the files a given target depends on. For Go programs, this is the program's main Go file, and all non-test Go files in directories corresponding to packages the main Go file depends upon (including transitive dependencies). This adds a Make macro using go list to retrieve a package's dependencies, and constructs the corresponding list of files to use as target prerequisites. Signed-off-by: Stephen Kitt <[email protected]>
|
🤖 Closed branches: [z_pr3239/skitt/pkgdeps] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For best results, Make should be told about all the files a given target depends on. For Go programs, this is the program's main Go file, and all non-test Go files in directories corresponding to packages the main Go file depends upon (including transitive dependencies).
This adds a Make macro using go list to retrieve a package's dependencies, and constructs the corresponding list of files to use as target prerequisites.