Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Endpoint plural IP fields instead of singular fields #3282

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Use Endpoint plural IP fields instead of singular fields #3282

merged 4 commits into from
Jan 23, 2025

Conversation

tpantelis
Copy link
Contributor

Also mark the singular fields as deprecated so the staticcheck linter flags any usages outside the package.

@tpantelis tpantelis self-assigned this Jan 22, 2025
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3282/tpantelis/use_endpoint_ips
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

skitt
skitt reviewed Jan 23, 2025
View reviewed changes
pkg/apis/submariner.io/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/submariner.io/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/submariner.io/v1/types.go Outdated Show resolved Hide resolved
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jan 23, 2025
@skitt skitt merged commit e5c545d into submariner-io:devel Jan 23, 2025
42 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3282/tpantelis/use_endpoint_ips]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yboaron yboaron yboaron approved these changes

@skitt skitt skitt approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees

@tpantelis tpantelis

Labels
ready-to-test When a PR is ready for full E2E testing
Projects
Submariner 0.20
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tpantelis @submariner-bot @dfarrell07 @skitt @yboaron