-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
font switcher #604
font switcher #604
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
(also system-ui probably isn't the best sans option) |
Shouldn't the toggle icon be reversed? When we're on the serif font page, the switcher should display the sans-serif icon, and when we're on the sans-serif page, it should show the serif icon. But I see the same 'reverse psychology' is used for the dark/light theme button as well! :-) EDIT: The reverse—showing the current setting—can sometimes feel confusing because users might assume that’s the state they’re switching to, not the one they’re already in. That said, there are successful apps using both approaches, especially when aiming for a “live preview” feel (e.g., showing the current style applied to the icon itself). In short, showing the next option tends to be more widely understood, though some user preferences and app styles may favor the current-state display. It really is like the old analog console or wall toggle buttons, you press the option that you want to happen. |
good point! #718 |
WIP. Need a better icon, and some of the variables could probably use more tweaking