chore: tweak dark mode backgrounds #699
Conversation
dummdidumm
commented
Oct 29, 2024
•
dummdidumm
commented
- make the darkest one a bit lighter (else it's just too dark)
- turn down background saturation to give the whole thing a bit of a warmer feeling (the blue makes it overly cold)
- remove blue from text, makes it brighter yet more pleasing to the eye
- make the darkest one a bit lighter (else it's just too dark) - turn down saturation to give the whole thing a bit of a warmer feeling (the blue makes it overly cold)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
the background seems too light with this. I prefer the greater contrast on the currently deployed version most sites are pretty dark in dark mode. e.g. I just checked https://vite.dev/guide/ and the background is pretty dark there |
|
It doesn't feel warmer to me, just greyer. Admittedly it's hard to judge a dark theme when I'm near a window |
|
I actually turned off all my lights and drew my blinds while testing this 😆 |
Blue == cold, less blue == warmer, even if it's just greyer.
You're doing this wrong, people primarily use dark mode during the day, so it's a feature of this whole thing being lighter.
This PR has a darker background than your example. Just proves my point that the current dark is too dark/cold. We can make the text a notch lighter if that's what you're saying. |
In the colour theory sense, yes. I'm talking about how it feels. We associate bright blue skies with warmth, for example! In this case the deep blue feels to me like a luxurious velvet robe whereas the grey feels impersonal and sci-fi-ish. I don't actually think either is quite right — I can't tell if it needs to be something in between or something off to one side.
People baffle me.
Worth noting that the situation is reversed over there — they have a darker sidebar and a lighter main content area, whereas we have the opposite. |
I think it's mostly around neutrality, and given different people have different preferences with regards to color it could work well for the largest group of people. If you want to keep some kind of colored background, then we could go into the red, mirroring the Svelte orange. A hue of 300 with a saturation of 10% for example |
|
300 is purple and looks absolutely mad: 
The Svelte orange hue is 12, and with 10% saturation at various lightnesses it looks... not great honestly: 
A bluish tint works partly because it's very common and feels night-time-ish, but partly because it contrasts with the orange rather than using it. Is there an issue where people have complained about the background colour? I remember when we first introduced it (replacing the greys we'd had prior to that point) and everyone on the team was like 'oh my god this looks so much better'. Again, not saying it's perfect now — it's definitely not — but this feels like a step back towards where we were prior to that. |
I myself find the dark mode off-putting, it's straining on my eyes because the background is so dark, yet the text has this tint of blue and so even if it has high contrast on paper it still feels washed out. Also these people: #517 (comment) This PR tries to find a sweet spot between having that aesthetic blue and making the background lighter to make it more pleasant on the eyes. |
|
Vite's main content is lighter, but the page is on average darker because their left nav is so much darker than ours. I just tried this PR with changing the nav to a much darker color and it looks much better to me. What do you think about trying that out? |
|
merged #765, closing |
