Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Gadget Metadata #274

Merged
merged 12 commits into from
Sep 18, 2024
Merged

[feat] Gadget Metadata #274

merged 12 commits into from
Sep 18, 2024

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Sep 16, 2024

This PR introduces an easier way to define your gadget sources in your Cargo.toml

It is not, However, a new way that we created, it is actually encouraged by Cargo to let other tools embed extra metadata that could be later on used by these tools, see: for more information.

In our case, you can define your gadget metadata related to where we find your gadget binaries like the following:

[[package.metadata.gadget.Native.sources]]
owner = "webb-tools"
repo = "incredible-squaring"
tag = "0.1.0"
binaries = [
    { arch = "Amd64", os = "Linux", name = "amd64-linux-incredible-squaring-gadget" },
    { arch = "Arm64", os = "Linux", name = "arm64-linux-incredible-squaring-gadget" },
]

Open Questions

  • In Github CI, we should update the blueprint.json with the SHA256 of the release binaries, that could be a separate task, or we could create our own github action.
  • Blueprint Specification (blueprint.json), potentially, should be attached to each github release.

@shekohex shekohex marked this pull request as ready for review September 16, 2024 18:11
@shekohex shekohex marked this pull request as draft September 16, 2024 18:11
@drewstone
Copy link
Contributor

What task is this for?

@tbraun96 tbraun96 changed the title [feat] Gadget Meatadata [feat] Gadget Metadata Sep 16, 2024
@shekohex
Copy link
Contributor Author

What task is this for?

Ah, This PR is to replace the old task defined here: #253

@shekohex shekohex marked this pull request as ready for review September 17, 2024 15:24
@drewstone
Copy link
Contributor

One more CI task to fix.

@shekohex
Copy link
Contributor Author

@drewstone it is failing since #246 I would mention @Serial-ATA here to investigate more in his PR.

@shekohex shekohex merged commit 79578d4 into main Sep 18, 2024
5 of 6 checks passed
@shekohex shekohex deleted the shady/gadget-metadata branch September 18, 2024 18:00
@Serial-ATA
Copy link
Contributor

Yeah, #246 wasn't tested on the CI changes in #284. I'll take a look.

@webb-spider webb-spider bot mentioned this pull request Sep 23, 2024
@webb-spider webb-spider bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants