-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Gadget Metadata #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What task is this for? |
This was referenced Sep 16, 2024
Ah, This PR is to replace the old task defined here: #253 |
tbraun96
approved these changes
Sep 18, 2024
One more CI task to fix. |
@drewstone it is failing since #246 I would mention @Serial-ATA here to investigate more in his PR. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an easier way to define your gadget sources in your Cargo.toml
It is not, However, a new way that we created, it is actually encouraged by Cargo to let other tools embed extra metadata that could be later on used by these tools, see: for more information.
In our case, you can define your gadget metadata related to where we find your gadget binaries like the following:
Open Questions
blueprint.json
with the SHA256 of the release binaries, that could be a separate task, or we could create our own github action.