Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~constants~ should not autolink #285

Merged
merged 1 commit into from
Jan 12, 2021
Merged

~constants~ should not autolink #285

merged 1 commit into from
Jan 12, 2021

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jan 10, 2021

This is necessary so that if you happen to have a constant with the same name as an abstract operation, the former will not be treated as a reference to the latter.

(This comes up with, for example, ~ConstructorMethod~ as the return value of ClassElementKind together with ConstructorMethod as a syntax-directed operation. That particular example is only an issue if SDOs are treated as abstract operations for the purposes of autolinking.)

Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a warning mechanism? It'd be nice for readers not to have to consider these things to be in different namespaces. Still, this is better than the current incorrect behaviour, so approving.

@bakkot bakkot mentioned this pull request Jan 12, 2021
@bakkot
Copy link
Contributor Author

bakkot commented Jan 12, 2021

Do we have a warning mechanism?

Added a desiderata to #173.

@bakkot bakkot merged commit aace748 into master Jan 12, 2021
@bakkot bakkot deleted the const-not-ref branch January 12, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants