Allow linter to use alternate features.txt file #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this what #3940 is for? |
|
#3940 is related to this. We plan to have a V8 side copy of features.txt that we will 2-way-sync with the one here. This change is to allow us to use our copy of features.txt file when linting our test changes. Once we successfully ran the linter in V8 we are sure we can export to this repo both the tests and any updates to the features.txt file we might have needed. |
ptomato
approved these changes
Oct 16, 2023
|
Thanks! I guess I only need to wait for the failed check approval now. Or, how does this work? |
|
Just needs to be rebased; and a maintainer can approve CI and land it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 explores 2-way-sync-ing of tests and needs to be able to introduce new features and tests first in V8 repo before exporting them to test262 github repo. Linting these tests requires the linter to become a bit more flexible with where it looks for the features file.