Some extra test coverage for Temporal #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
force-pushed
the
temporal-editorial
branch
from
dad87e7 to
8f1e7cd
Compare
Ms2ger
requested changes
Oct 18, 2023
ptomato
force-pushed
the
temporal-editorial
branch
from
315b4df to
4043559
Compare
Ms2ger
approved these changes
Oct 18, 2023
Test case based on one provided by Anba. See issue: tc39/proposal-temporal#2697
In PlainYearMonth arithmetic, we need to find the end of the month when adding a negative duration or subtracting a positive one. This end of the month can be out of range. Test case based on one provided by Anba. See issue: tc39/proposal-temporal#2700
…ants In the AO DisambiguatePossibleInstants, a PlainDateTime instance is passed to user code. This instance should have the built-in ISO 8601 calendar. Here are some tests that ensure it does. See tc39/proposal-temporal#2671.
This adds coverage for each possible outcome of compare(), where each unit is greater, lesser, or equal.
ptomato
force-pushed
the
temporal-editorial
branch
from
4043559 to
6d92079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is some extra test coverage for Temporal for gaps that were highlighted by some editorial issues that @anba reported.
None of this reflects any changed behaviour, just coverage gaps.
See tc39/proposal-temporal#2708.