More versioning-3 tests #6910
Open
More versioning-3 tests #6910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahabT
approved these changes
Nov 29, 2024
carlydf
changed the title
…ral into cdf/more-versioning-tests
ShahabT
reviewed
Dec 9, 2024
Comment on lines
+67
to
+76
| dynamicconfig.MatchingForwarderMaxChildrenPerNode.Key(): partitionTreeDegree, | ||
|
|
||
| // Make sure we don't hit the rate limiter in tests | ||
| dynamicconfig.FrontendGlobalNamespaceNamespaceReplicationInducingAPIsRPS.Key(): 1000, | ||
| dynamicconfig.FrontendMaxNamespaceNamespaceReplicationInducingAPIsBurstRatioPerInstance.Key(): 1, | ||
| dynamicconfig.FrontendNamespaceReplicationInducingAPIsRPS.Key(): 1000, | ||
|
|
||
| // this is overridden for tests using RunTestWithMatchingBehavior | ||
| dynamicconfig.MatchingNumTaskqueueReadPartitions.Key(): 4, | ||
| dynamicconfig.MatchingNumTaskqueueWritePartitions.Key(): 4, |
There was a problem hiding this comment.
These configs should only be needed for tests dealing matching behaviors, I believe. can you try removing them?
| } | ||
| } | ||
|
|
||
| func (s *DeploymentSuite) TestUpdateWorkflowExecutionOptions_ChildWorkflowWithSDK() { |
There was a problem hiding this comment.
I thought we want to use verisoning_3_test for testing versioning behaviors/overrides, etc, and keep deployment_test for deployment APIs.
There was a problem hiding this comment.
Ah yes, I can move stuff over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
testpoller-based test for inheriting VersioningOverride from parent to child workflowtestpollertoolWhy?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?