Fix stream sender update ack level on empty task #7061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai719
reviewed
Jan 8, 2025
| @@ -510,10 +506,15 @@ Loop: | |||
| return err | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
should we reset skipCount after we send the watermark?
hehaifengcn
reviewed
Jan 8, 2025
| @@ -489,10 +489,6 @@ Loop: | |||
| return fmt.Errorf("ReplicationServiceError StreamSender unable to get next replication task: %w", err) | |||
| } | |||
|
|
|||
| if !s.shouldProcessTask(item) { | |||
There was a problem hiding this comment.
line 562 below https://github.com/temporalio/temporal/pull/7061/files#diff-3a5383e58f4357884dc90cd45cdc6b2650d1bf8e59c6dbb2d78ca561af96da57R562 , the code will send WorkflowReplicationMessages with endExclusiveWatermark. That is not enough to update Ack level?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix stream sender update ack level on empty task
Why?
If there is no replication task between two cells, we should still update the ack level.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?