[gha][binary sizes] Use the input context to read the toolchain_version #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this workflow read the toolchain_version input using `github.event.inputs` which carries the same `event` values as the calling workflow This means `github.event.inputs` is empty when the workflow is triggered via workflow_call and the calling worfklow was triggered as part of a `schedule` event. This was not caught during testing because we triggered the calling worfklow using the `pull_request` event instead. This change switches to using the `input` context which is always set to the correct value regardless if whether our workflow is triggered via `pull_request`, `workflow_call` or `workflow_dispatch`.
compnerd
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow is failing to run when new swift toolchain releases are created because
toolchain_versionis resolved to the branch name ("main") after the initialcontextjob, rather than the newly released swift toolchain version. The bug is in the callee (release-swift-toolchain-binary-sizes.yml) rather than the caller (workflow-run-release-swift-toolchain-binary-sizes.yml), which is correctly looking up and passing the toolchain version along in its workflow invocation.This is happening because the callee reads the
toolchain_versioninput usinggithub.event.inputswhich is empty if the caller is triggered by aworkflow_runevent which has no inputs: The caller'sgithub.event.inputsis always forwarded to the callee forworkflow_runevent triggers.This was not caught during testing because in presubmit we trigger the caller using
pull_requestrather thanworkflow_run, and we look for a hard-coded test toolchain version since no latest version is available. This change switches the callee to use theinputcontext which always has the correct value regardless of whether the triggering event isworkflow_call(whereby we inheritgithub.eventfrom the caller) orworkflow_dispatch(whereby the inputs are passed directly to the workflow by the user).