-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Current window position #130
feat: Current window position #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! We can design this API to have a closer shape to the Element
API. I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, the new Window struct is looking good, we just need an accessor from Session so that we don't need to duplicate members there.
My most recent commit should address all the comments. Sorry for the delay I've been running through the interview circuit so not a lot of free time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating! The docs now need to be updated but the code looks good!
Attempted a merge in the GitHub actions editor, hopefully I didn't mess it up. |
Oops I messed up the merge by adding |
Just pushed up a fix for that @tristanlabelle this is ready to go. |
Implements the following functions:
/session/:sessionId/window/:windowHandle/maximize
/session/:sessionId/window/:windowHandle/position