Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UriRenderer interface #154

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Improve UriRenderer interface #154

merged 1 commit into from
Jan 23, 2025

Conversation

nyamsprod
Copy link
Member

Adding the following named constructors on the Uri class:

  • Uri::fromMarkdownAnchor
  • Uri::fromHtmlAnchor
  • Uri::fromHtmlLink
  • Uri::fromHeaderLinkValue

And their corresponding renderer methods to the UriRenderer interface:

  • Uri::toMarkdownAnchor
  • Uri::toHtmlAnchor
  • Uri::toHtmlLink
  • Uri::toHeaderLinkValue

@nyamsprod nyamsprod added the enhancement New feature or request label Jan 23, 2025
@nyamsprod nyamsprod self-assigned this Jan 23, 2025
@nyamsprod nyamsprod force-pushed the feature/improve-uri-renderer-interface branch 2 times, most recently from e234ab2 to 4e345a9 Compare January 23, 2025 22:17
@nyamsprod nyamsprod force-pushed the feature/improve-uri-renderer-interface branch from 4e345a9 to 13b2852 Compare January 23, 2025 22:20
@nyamsprod nyamsprod merged commit 925743d into master Jan 23, 2025
16 checks passed
@nyamsprod nyamsprod deleted the feature/improve-uri-renderer-interface branch January 23, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nyamsprod nyamsprod

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nyamsprod