Merge pull request #120 from tighten/feat/fillable-trait

Merge child class fillable traits with those of the parent class

src/HasParent.php

@@ -116,7 +116,7 @@ public function getMorphClass(): string
 
         return (new $parentClass)->getMorphClass();
     }
-    
+
     /**
      * Get the class name for poly-type collections
      *
@@ -140,4 +140,23 @@ protected function getParentClass(): string
 
         return $parentClassName ?: $parentClassName = (new ReflectionClass($this))->getParentClass()->getName();
     }
+
+
+    /**
+     * Merge the fillable attributes for the model with those of its Parent Class
+     *
+     * @return array<string>
+     */
+    public function getFillable()
+    {
+        $parentClass = $this->getParentClass();
+
+        if ((new ReflectionClass($parentClass))->isAbstract()) {
+
+            return $this->fillable;
+        }
+        $parentFillable = (new $parentClass)->getFillable();
+
+        return array_unique(array_merge($parentFillable, $this->fillable));
+    }
 }

tests/Features/ChildModelFillablesMergeWithParentModelFillablesTest.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace Parental\Tests\Features;
+
+use Parental\Tests\Models\Event;
+use Parental\Tests\Models\Workshop;
+use Parental\Tests\TestCase;
+
+class ChildModelFillablesMergeWithParentModelFillablesTest extends TestCase
+{
+    /** @test */
+    function child_fillables_are_merged_with_parent_fillables()
+    {
+        $workshop = Workshop::create([
+            'name' => 'Scaling Laravel',
+            'industry' => 'Technology',
+            'skill_level' => 'Advanced',
+        ]);
+
+        $event = Event::first();
+
+        $this->assertEquals($event->name, $workshop->name);
+    }
+}

tests/Models/Conference.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Parental\Tests\Models;
+
+use Parental\HasParent;
+
+class Conference extends Event
+{
+    use HasParent;
+
+    protected $fillable = ['industry'];
+}

tests/Models/Event.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Parental\Tests\Models;
+
+use Illuminate\Database\Eloquent\Model;
+
+class Event extends Model
+{
+    protected $fillable = ['name', 'type'];
+}

tests/Models/Workshop.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Parental\Tests\Models;
+
+use Parental\HasParent;
+
+class Workshop extends Event
+{
+    use HasParent;
+
+    protected $fillable = ['industry', 'skill_level'];
+}

tests/TestCase.php

@@ -110,5 +110,14 @@ public function runMigrations()
             $table->string('type')->nullable();
             $table->timestamps();
         });
+
+        Schema::create('events', function ($table) {
+            $table->increments('id');
+            $table->string('type')->nullable();
+            $table->string('name');
+            $table->string('industry')->nullable();
+            $table->string('skill_level')->nullable();
+            $table->timestamps();
+        });
     }
 }